ci: test against the current Node.js nightly major - #5654
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5654 +/- ##
==========================================
+ Coverage 93.42% 93.45% +0.02%
==========================================
Files 110 110
Lines 38723 38723
==========================================
+ Hits 36178 36188 +10
+ Misses 2545 2535 -10 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
Author
|
Both failures are from main, not this branch. CodeQL: #5634 bumped init to 4.37.3 but left autobuild and analyze at The node 24 one is http2-request-never-settles.js, which dies with SIGSEGV Will rebase once #5655 is in. |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This relates to...
Fixes #5469.
Rationale
Node 25 nightlies stopped in February when main moved on, and we are on
v27 now, but this workflow still asks for 25. So test-shared-builtin
downloads the same February tarball every night, v25.6.1-nightly20260209,
and runs its frozen test suite against current undici. Six of its
client-proxy tests fail because nodejs/node@0c138da5 updated them in July
for the 8.7.0 proxy behaviour, and the February copy still expects
CONNECT.
The 25-nightly test and autobahn jobs sit on those same old builds. They
stay green, so nothing has been testing current nightlies at all.
Changes
Look up the newest nightly major from the download index and pass it to
test, autobahn and test-shared-builtin, so this does not need bumping
again when main moves to 28.
report-failure now also fires when that lookup fails, instead of skipping
the whole suite quietly.
Features
N/A
Bug Fixes
N/A, CI only.
Breaking Changes and Deprecations
N/A
Status
against the live index: the old code resolves the February tarball,
the new code resolves today's v27 nightly. I could not run
test-shared-builtin end to end, since fork runs skip on the
repository guard.