fix(test): skip cache-tests when submodule is missing - #5661
Open
edenbuilds wants to merge 2 commits into
Open
Conversation
CITGM installs the published package without git submodules, so test/fixtures/cache-tests is empty and importing the runner fails the suite. Exit cleanly with a warning when the checkout is absent (fixes nodejs#5642).
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5661 +/- ##
==========================================
+ Coverage 93.43% 93.45% +0.02%
==========================================
Files 110 110
Lines 38733 38776 +43
==========================================
+ Hits 36190 36239 +49
+ Misses 2543 2537 -6 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Author
|
CI note: the Node 24/26 failures are in |
Previous run failed only on test/http2-request-never-settles.js; this change is unrelated to the cache-tests submodule skip.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
npm testrunstest:cache-tests, which importstest/fixtures/cache-tests/.../runner.mjs.Cannot find module '.../runner.mjs'(Test failure on CITGM for Node.js 26.6.0 #5642).Fixes #5642
Test plan
test/fixtures/cache-tests(no submodule):node test/cache-interceptor/cache-tests.mjs --ciexits 0 and prints the skip warningMade with Cursor