Skip to content

fix(dict): flash relationship after scroll settles - #46

Open
damusix wants to merge 1 commit into
mainfrom
fix/dict-flash-after-scroll
Open

fix(dict): flash relationship after scroll settles#46
damusix wants to merge 1 commit into
mainfrom
fix/dict-flash-after-scroll

Conversation

@damusix

@damusix damusix commented Sep 13, 2026

Copy link
Copy Markdown
Contributor

Summary

  • wait for the Dictionary browse-lens scroll position to settle before flashing a relationship target
  • require the target to be visible and cancel stale flashes on newer navigation
  • honor reduced-motion preferences with instant scrolling
  • update the visual regression and spotlight design/spec contracts

Verification

  • bun run build:bundle
  • bun test/visual/test-dd-spotlight-grid.ts — CP5 passed: no early flash, 100 ms scroll quiet period, target visible at flash start, class removed on animation end
  • visually reviewed tmp/dd-spotlight-grid/29-cp5-after-chip-click.png

The broader visual script passed the relevant CP5 checkpoint and continued through CP14, then stopped at the unrelated CP15 synthetic-model server startup check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant