Conversation
* feat(tui): track update download progress from observer events The updater has emitted received/total every 512KB and a retry notice all along; nothing in the TUI listened. Mirrors useTransferProgress so the update screen can show real progress instead of a bare spinner. * feat(tui): render download progress on the update screen The installing state was a bare spinner for the whole of a ~70MB download, indistinguishable from a hang. Shows MB, percent and a bar once the total is known, MB alone when the server sends no Content-Length, and the retry reason so a resume does not read as one. * refactor(cli): correct a comment promising a fallback that never existed The comment claimed piped output falls back to periodic newlines; it prints nothing, and suppression is right, since a tick per 512KB would bury a CI log. Behaviour is unchanged, the early return just replaces formatting a line that was already being discarded. * docs(tui): add the Update screen to the screen reference The screen reference had no entry for it at all, so the download progress, the unknown-size fallback and the resume notice were undocumented. * docs(update): bring the spec up to standard and drop a drawn mockup The spec was missing the change tree, outline, flows, risks and change log a sibling spec two commits earlier already carried; its approaches table moves to a design doc. The screen reference loses a hand-drawn progress bar, the artifact class the VHS pipeline exists to retire. * chore(changeset): add update download progress Every user-facing change in this repo carries one; this had none.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The updater has emitted received/total every 512KB and a retry notice all along; nothing in the TUI listened. Mirrors useTransferProgress so the update screen can show real progress instead of a bare spinner.
The installing state was a bare spinner for the whole of a ~70MB download, indistinguishable from a hang. Shows MB, percent and a bar once the total is known, MB alone when the server sends no Content-Length, and the retry reason so a resume does not read as one.
The comment claimed piped output falls back to periodic newlines; it prints nothing, and suppression is right, since a tick per 512KB would bury a CI log. Behaviour is unchanged, the early return just replaces formatting a line that was already being discarded.
The screen reference had no entry for it at all, so the download progress, the unknown-size fallback and the resume notice were undocumented.
The spec was missing the change tree, outline, flows, risks and change log a sibling spec two commits earlier already carried; its approaches table moves to a design doc. The screen reference loses a hand-drawn progress bar, the artifact class the VHS pipeline exists to retire.
Every user-facing change in this repo carries one; this had none.