ci(dox): deploy after the Release workflow, not beside it - #280
Merged
Merged
Conversation
Dox deployed on every push to main, in parallel with the Release workflow. On a push that publishes, the docs could build before the `@northguild/gmt@X.Y.Z` tag existed. - Trigger on `workflow_run` of Release (completed, on main). Release runs on every push to main, so every merge still deploys, now after its tag is pushed. - Check out the commit Release ran on, with full history and tags. - The daily schedule and `workflow_dispatch` are unchanged. Failure mode: if Release stops running on pushes to main, merges stop deploying the docs; the schedule and manual trigger still work. The workflow header and context/dox/built.md say so.
3 tasks
craig-o-curtis
added a commit
that referenced
this pull request
Sep 24, 2026
- `transitTime` keeps a comma-fraction offset (`+05:30:00,5`) as written; the capture is built from the canonical `EXTENDED_UTC_OFFSET`. - New `internal/wallClockAtOffset`, shared by `transitTime` and `fromOffsetInstant`, holds the range-limit wall-clock shift once. - One `TIME_ZONE_ANNOTATION` rule (RFC 9557) feeds `transitTime`, `zonedWallClockDifference` and `toOffsetInstant`; the Dox widget's stale copy is removed. - `deps.mjs`: `orderOf` fills the build order on first use. - Namespace lists gain `interval/` and `transport/`. - The deploy workflow change moves to #280; this branch restores `deploy-dox.yml` to main and points its comments there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split out of #279 at @baldurpan's suggestion, so the pipeline change can be reviewed on its own.
What changes
deploy-dox.ymlnow triggers onworkflow_runof Release (completed,main) instead of on push.main, so every merge still deploys the docs. The deploy now starts after Release finishes, not alongside it.@northguild/gmt@X.Y.Ztag. Running in parallel, the docs could build before that tag existed. feat(transport) TRAN-8 transitTime etaAtZone dwellTime #189 #192 #279 adds reference badges that read the newest tag, and this ordering is what keeps a just-released function from being badged Unreleased.workflow_run.head_sha), with full history and tags.workflow_dispatch.context/dox/built.md: the deploy rule is rewritten. It also said there was no manual trigger, which was already untrue.Failure mode
If Release ever stops running on pushes to
main(renamed, disabled, or given a path filter), merges stop deploying the docs. The daily schedule and the manual trigger still deploy. The workflow header says this.Merge order
Merge this before the next release PR. Otherwise that release's own functions keep the Unreleased badge until the next deploy, and the daily schedule catches it within a day.
Verification
name: Releaseinrelease.ymlmatchesworkflows: [Release].release.ymltriggers on every push tomainwith no path filter.workflow_runtrigger only takes effect from the default branch, so the first run of the new trigger comes after this merges.