feat(dox): sun-lit shading and atmosphere on the globe - #284
Merged
Merged
Conversation
Shade the globe per pixel from the sun's real position instead of flat day and night fills. Stacked translucent caps were tried first and left rings on the day side and stripes near the edge. - Day light follows Lambert's cosine law, gamma-encoded, and carries into civil twilight; night eases in over 18° of twilight. - A thin haze on the lit edge, and a glow ring outside the globe that is strongest on the sun's side and brightens when backlit. - City lights switch on at civil dusk, not at the horizon. - Ordered dither against 8-bit banding; the buffer is repainted only when the view or the sun moves. - Glow and haze are tokens, turned off under reduced transparency and raised contrast.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shade the globe per pixel from the sun's real position instead of flat day and night fills. Stacked translucent caps were tried first and left rings on the day side and stripes near the edge.
Changes
New pure module
apps/dox/src/lib/globe-shading.tswith its own tests;context/dox/built.mdrecords the design.Why a separate PR
This commit was first carried on #282 (INT-58 billingTimeline). It is split out so it can get its own visual review.