P1: add process_resize and advertise runner-owned process lifetime - #62
Merged
Merged
Conversation
MCP/HTTP disconnect keeps managed processes running; UDS worker loss and gateway shutdown still terminate the owned subtree. Spawn size stays 24x80. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
process_resizefor running PTY processes. Spawn stays 24×80;exec_commanddoes not gaintty_size.resize_supported: trueandexecution.process.capabilities.lifetime(owner=runner, client disconnect keeps running, UDS/gateway death terminates, no restart recovery).WIRE_PROTOCOLto 5. Pipe resize isPROCESS_NOT_TTY; exited handles arePROCESS_NOT_RUNNING.Test plan
cargo test -p codespace-domain --offlinecargo test --manifest-path crates/pty/Cargo.toml --offlinecargo test -p codespace-runner --offline(resize + UDS)cargo test -p codespace-server --offline --lib -- mcp::testscargo test -p codespace-server --offline --test process -- process_resize exec_command_schema exec_tty http_disconnectcargo test -p codespace-server --offline --test protocol_compat --test http_contract --test stdio_contract --test transport_contractcargo test --offline --test e2ecargo test --manifest-path crates/codex-runtime/Cargo.toml --offline --test runtime_binarycargo clippy -p codespace-domain -p codespace-runner -p codespace-server --all-targets --offline -- -D warningspython3 scripts/check_docs.py checkOut of scope
exec_command.tty_size, per-commandkill_on_disconnectprocess_find, hooks/skillsMade with Cursor