Skip to content

Go 1.26 - #163

Merged
roman-khimov merged 4 commits into
masterfrom
go-1.26
Aug 27, 2026
Merged

Go 1.26#163
roman-khimov merged 4 commits into
masterfrom
go-1.26

Conversation

@AnnaShaleva

@AnnaShaleva AnnaShaleva commented Aug 26, 2026

Copy link
Copy Markdown
Member

Close #156.

roman-khimov
roman-khimov previously approved these changes Aug 26, 2026
@roman-khimov

Copy link
Copy Markdown
Member

Red

@codecov

codecov Bot commented Aug 27, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 33.33333% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 62.34%. Comparing base (4614a37) to head (592739d).

Files with missing lines Patch % Lines
internal/simulation/main.go 0.00% 2 Missing ⚠️
internal/consensus/amev_block.go 0.00% 1 Missing ⚠️
internal/consensus/recovery_message.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #163      +/-   ##
==========================================
+ Coverage   57.65%   62.34%   +4.68%     
==========================================
  Files          33       32       -1     
  Lines        1913     1572     -341     
==========================================
- Hits         1103      980     -123     
+ Misses        717      591     -126     
+ Partials       93        1      -92     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@AnnaShaleva

Copy link
Copy Markdown
Member Author

Yes, happens due to Go 1.26 changes like this one:

[crypto/ecdh](https://go.dev/pkg/crypto/ecdh/)[¶](https://go.dev/doc/go1.26#cryptoecdhpkgcryptoecdh)

The random parameter to [Curve.GenerateKey](https://go.dev/pkg/crypto/ecdh#Curve.GenerateKey) is now ignored. Instead, it now always uses a secure source of cryptographically random bytes. For deterministic testing, use the new [testing/cryptotest.SetGlobalRandom](https://go.dev/pkg/testing/cryptotest#SetGlobalRandom) function. The new GODEBUG setting cryptocustomrand=1 temporarily restores the old behavior.

The new [KeyExchanger](https://go.dev/pkg/crypto/ecdh#KeyExchanger) interface, implemented by [PrivateKey](https://go.dev/pkg/crypto/ecdh#PrivateKey), makes it possible to accept abstract ECDH private keys, e.g. those implemented in hardware.

Fixed.

@AnnaShaleva
AnnaShaleva dismissed roman-khimov’s stale review August 27, 2026 08:09

Changes are introduced.

Comment thread internal/crypto/ecdsa_test.go Outdated
Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
@roman-khimov
roman-khimov merged commit bec4424 into master Aug 27, 2026
11 of 12 checks passed
@roman-khimov
roman-khimov deleted the go-1.26 branch August 27, 2026 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Go 1.26 upgrade check list

2 participants