Optimize buffering of forwarded SEARCH requests by cthulhu-rider · Pull Request #4116 · nspcc-dev/neofs-node

cthulhu-rider · 2026-08-05T15:27:41Z

No description provided.

codecov · 2026-08-05T15:32:19Z

Codecov Report

❌ Patch coverage is 2.77778% with 105 lines in your changes missing coverage. Please review.
✅ Project coverage is 30.08%. Comparing base (d897b93) to head (60d9d35).
⚠️ Report is 1 commits behind head on master.

Files with missing lines	Patch %	Lines
pkg/services/object/server.go	0.00%	51 Missing ⚠️
pkg/services/object/proto.go	0.00%	26 Missing ⚠️
pkg/services/object/get.go	0.00%	14 Missing ⚠️
pkg/services/object/search.go	0.00%	14 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #4116      +/-   ##
==========================================
- Coverage   30.10%   30.08%   -0.02%     
==========================================
  Files         679      679              
  Lines       40886    40893       +7     
==========================================
- Hits        12310    12304       -6     
- Misses      28576    28589      +13

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

roman-khimov

We need to share this code with SDK, it's unmaintainable otherwise.

cthulhu-rider · 2026-08-07T08:58:40Z

We need to share this code with SDK, it's unmaintainable otherwise.

this is planned to be done in #4005

roman-khimov · 2026-08-07T09:16:11Z

Let's solve #4005 first then.

cthulhu-rider · 2026-08-07T10:31:36Z

Let's solve #4005 first then.

i don't think it's worth blocking optimizations with refactorings

roman-khimov · 2026-08-07T12:50:16Z

It's too easy to lose control over the codebase this way, we need to structure our changes appropriately as early as possible.

cthulhu-rider · 2026-08-07T13:06:35Z

It's too easy to lose control over the codebase this way, we need to structure our changes appropriately as early as possible.

agree. But at the same time the more usecases are created, the easier it will be to form libs

i'll try my best to synthesize SDK packages asap

carpawell · 2026-08-10T12:53:16Z

 	}
 	if n != len(buf) {
-		return nil, fmt.Errorf("got wrong request length: expected %d, got %d", n, len(buf))
+		return nil, newWrongRequestLengthError(len(buf), n)


why in this commit?

one more usecase appears

what this error means for a user btw? isnt it a panic?

internal server error. Can be a panic. Should never happen anyway

carpawell · 2026-08-10T15:55:41Z

 		1 + maxGetResponseChunkVarintLen // 1 for iprotobuf.TagBytes2
 	getResponseChunkBufferLen = maxChunkOffsetInGetResponse + maxGetResponseChunkLen + maxResponseVerificationHeaderLen
+
+	modernRequestVerificationSignatureCount = 2


make it api dependent? we will have nspcc-dev/neofs-api#406 soon, it will then be "the most modern"

it is API dependent. To support new API feature, future change is inevitable

carpawell · 2026-08-10T16:06:41Z

+	MarshalStable([]byte)
+}
+
+func writeStablyMarshalledField(buf []byte, tag byte, ln int, fld stablyMarshalledFIeld) int {


can ln and fld merged into a single interface? likely every our struct will handle it ok

length of embedded messages is always needed twice: to calc whole message len and to write field prefix. So, i dont like the idea to calc it twice

carpawell · 2026-08-10T16:23:58Z

 	}
 	if n != len(buf) {
-		return nil, fmt.Errorf("got wrong request length: expected %d, got %d", n, len(buf))
+		return nil, newWrongRequestLengthError(len(buf), n)


what this error means for a user btw? isnt it a panic?

roman-khimov

Needs to be shared with SDK code.

cthulhu-rider · 2026-08-25T18:03:04Z

blocked by:

roman-khimov · 2026-08-27T08:52:28Z

Linter.

Server-side part of nspcc-dev/neofs-sdk-go@c4dda73. Additionally de-duplicates the request encoding for sending to multiple nodes. Refs #4005. Signed-off-by: Leonard Liubich <leonard@morphbits.io>

roman-khimov · 2026-08-27T10:00:13Z


-	connAPIVersion := conn.APIVersion()
+	connAPIVersionMsg := conn.APIVersion()
+	connAPIVersion := version.New(connAPIVersionMsg.GetMajor(), connAPIVersionMsg.GetMinor())


Previous API was made to optimize out version->protorefs conversion, now we have protorefs->version. Maybe we need to change the API then.

cthulhu-rider force-pushed the search-buffers branch from 4347a87 to 1695f41 Compare August 5, 2026 15:28

cthulhu-rider marked this pull request as ready for review August 5, 2026 15:43

cthulhu-rider requested review from End-rey, carpawell and roman-khimov as code owners August 5, 2026 15:43

cthulhu-rider force-pushed the search-buffers branch from 1695f41 to 5d595c6 Compare August 6, 2026 17:08

roman-khimov reviewed Aug 6, 2026

View reviewed changes

Comment thread pkg/services/object/search.go Outdated

cthulhu-rider force-pushed the search-buffers branch from 5d595c6 to ff70559 Compare August 7, 2026 14:40

carpawell reviewed Aug 10, 2026

View reviewed changes

cthulhu-rider force-pushed the search-buffers branch from ff70559 to 381aa09 Compare August 10, 2026 14:44

carpawell approved these changes Aug 10, 2026

View reviewed changes

cthulhu-rider force-pushed the search-buffers branch from 381aa09 to 4c3813e Compare August 10, 2026 16:39

roman-khimov requested changes Aug 19, 2026

View reviewed changes

cthulhu-rider force-pushed the search-buffers branch 2 times, most recently from f701151 to 7a069cc Compare August 26, 2026 19:32

roman-khimov reviewed Aug 27, 2026

View reviewed changes

cthulhu-rider force-pushed the search-buffers branch from 7a069cc to 53bf220 Compare August 27, 2026 07:33

cthulhu-rider force-pushed the search-buffers branch 3 times, most recently from e6b27c0 to 03c0100 Compare August 27, 2026 09:22

sn/object: Optimize buffering of forwarded SEARCH requests

60d9d35

Server-side part of nspcc-dev/neofs-sdk-go@c4dda73. Additionally de-duplicates the request encoding for sending to multiple nodes. Refs #4005. Signed-off-by: Leonard Liubich <leonard@morphbits.io>

cthulhu-rider force-pushed the search-buffers branch from 03c0100 to 60d9d35 Compare August 27, 2026 09:23

cthulhu-rider mentioned this pull request Aug 27, 2026

Clean up code for writing service messages #4005

Open

roman-khimov approved these changes Aug 27, 2026

View reviewed changes

roman-khimov merged commit fa949e8 into master Aug 27, 2026
20 of 22 checks passed

roman-khimov deleted the search-buffers branch August 27, 2026 10:05

Uh oh!

Conversation

cthulhu-rider commented Aug 5, 2026

Uh oh!

codecov Bot commented Aug 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

roman-khimov left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cthulhu-rider commented Aug 7, 2026

Uh oh!

roman-khimov commented Aug 7, 2026

Uh oh!

cthulhu-rider commented Aug 7, 2026

Uh oh!

roman-khimov commented Aug 7, 2026

Uh oh!

cthulhu-rider commented Aug 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

carpawell Aug 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

carpawell Aug 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

roman-khimov left a comment

Choose a reason for hiding this comment

Uh oh!

cthulhu-rider commented Aug 25, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

roman-khimov commented Aug 27, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codecov Bot commented Aug 5, 2026 •

edited

Loading

cthulhu-rider commented Aug 7, 2026 •

edited

Loading

carpawell Aug 10, 2026 •

edited

Loading

carpawell Aug 10, 2026 •

edited

Loading