Skip to content

Deduplicate request encoding on GET/HEAD forwarding - #4160

Merged
roman-khimov merged 3 commits into
masterfrom
forward-protobuf
Sep 1, 2026
Merged

Deduplicate request encoding on GET/HEAD forwarding#4160
roman-khimov merged 3 commits into
masterfrom
forward-protobuf

Conversation

@cthulhu-rider

Copy link
Copy Markdown
Contributor

No description provided.

@codecov

codecov Bot commented Aug 31, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 35.59322% with 76 lines in your changes missing coverage. Please review.
✅ Project coverage is 30.32%. Comparing base (b3cf705) to head (8917f5b).

Files with missing lines Patch % Lines
pkg/services/object/server.go 43.83% 41 Missing ⚠️
pkg/services/object/proto.go 30.30% 23 Missing ⚠️
pkg/services/object/get.go 0.00% 10 Missing ⚠️
pkg/services/object/search.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4160      +/-   ##
==========================================
+ Coverage   30.28%   30.32%   +0.03%     
==========================================
  Files         673      673              
  Lines       40648    40673      +25     
==========================================
+ Hits        12310    12333      +23     
- Misses      28338    28340       +2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cthulhu-rider
cthulhu-rider force-pushed the forward-protobuf branch 5 times, most recently from 276a84e to b37f82a Compare September 1, 2026 08:08
Follow 60d9d35.

Will be useful for #4078.

Signed-off-by: Leonard Liubich <leonard@morphbits.io>
So that it would be clear from code that the same pool is being used.

Signed-off-by: Leonard Liubich <leonard@morphbits.io>
@cthulhu-rider
cthulhu-rider force-pushed the forward-protobuf branch 2 times, most recently from 4c2c885 to ac67901 Compare September 1, 2026 08:11
Follow 60d9d35.

Signed-off-by: Leonard Liubich <leonard@morphbits.io>
@cthulhu-rider
cthulhu-rider marked this pull request as ready for review September 1, 2026 08:27
@roman-khimov
roman-khimov merged commit 51ac40d into master Sep 1, 2026
22 checks passed
@roman-khimov
roman-khimov deleted the forward-protobuf branch September 1, 2026 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants