test: remove redundant SIPL mount coverage - #232
Conversation
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
Included review availability: 4 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour. WalkthroughThe pull request removes one unit test from the container core test suite. The deleted test covered SIPL host paths and ChangesContainer test updates
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This change removes redundant SIPL-specific test coverage without changing product behavior, and the full unit test suite passes; no actionable merge-blocking risk remains. 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
Comment |
Summary
Remove the SIPL-specific device-mount test added by #231. It repeats the four list entries and the unchanged generic conditional-mount loop, while equivalent existing device paths have no dedicated tests.
Testing
platform linux -- Python 3.12.3, pytest-8.4.2, pluggy-1.6.0
rootdir: /home/agirault/projects/holoscan-cli/.worktrees/ag/sipl-host-assets
configfile: pyproject.toml
collected 49 items
tests/unit/test_container_core.py ...................................... [ 77%]
........... [100%]
============================== 49 passed in 0.07s ============================== (49 passed)
Summary by CodeRabbit