Skip to content

test: remove redundant SIPL mount coverage - #232

Open
agirault wants to merge 1 commit into
mainfrom
ag/remove-redundant-sipl-test
Open

test: remove redundant SIPL mount coverage#232
agirault wants to merge 1 commit into
mainfrom
ag/remove-redundant-sipl-test

Conversation

@agirault

@agirault agirault commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

Summary

Remove the SIPL-specific device-mount test added by #231. It repeats the four list entries and the unchanged generic conditional-mount loop, while equivalent existing device paths have no dedicated tests.

Testing

  • ============================= test session starts ==============================
    platform linux -- Python 3.12.3, pytest-8.4.2, pluggy-1.6.0
    rootdir: /home/agirault/projects/holoscan-cli/.worktrees/ag/sipl-host-assets
    configfile: pyproject.toml
    collected 49 items

tests/unit/test_container_core.py ...................................... [ 77%]
........... [100%]

============================== 49 passed in 0.07s ============================== (49 passed)

Summary by CodeRabbit

  • Tests
    • Removed an outdated unit test covering SIPL-related host mount behavior.

@copy-pr-bot

copy-pr-bot Bot commented Aug 28, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions

Copy link
Copy Markdown

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@coderabbitai

coderabbitai Bot commented Aug 28, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 077b338c-1d02-4314-af11-20d52f9c7ac1

📥 Commits

Reviewing files that changed from the base of the PR and between ebaf469 and f51e7b7.

📒 Files selected for processing (1)
  • tests/unit/test_container_core.py
💤 Files with no reviewable changes (1)
  • tests/unit/test_container_core.py

Included review availability: 4 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.


Walkthrough

The pull request removes one unit test from the container core test suite. The deleted test covered SIPL host paths and -v mount ordering.

Changes

Container test updates

Layer / File(s) Summary
Remove SIPL mount coverage
tests/unit/test_container_core.py
Removes the test for SIPL host paths and -v mount ordering.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to f51e7

This change removes redundant SIPL-specific test coverage without changing product behavior, and the full unit test suite passes; no actionable merge-blocking risk remains.

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: removing redundant SIPL mount test coverage.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant