fix(git): respect variable prefix indent when completing options#2506
Merged
Conversation
abeldekat
force-pushed
the
fix_git_completion
branch
from
July 10, 2026 12:00
f676d91 to
17a55a4
Compare
Member
Author
|
I pushed an update, removing the 'else' |
echasnovski
reviewed
Jul 10, 2026
abeldekat
force-pushed
the
fix_git_completion
branch
from
July 10, 2026 12:53
17a55a4 to
c3f6660
Compare
echasnovski
approved these changes
Jul 10, 2026
echasnovski
left a comment
echasnovski
left a comment
Member
There was a problem hiding this comment.
Thanks for looking into this!
echasnovski
force-pushed
the
fix_git_completion
branch
from
July 10, 2026 13:31
c3f6660 to
df6e222
Compare
echasnovski
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Git option completion fails when options are not indented by 7 spaces. Unfortunately, it seems that the number of spaces used varies per system.
This PR creates the regular expression dynamically, parsing the nr of spaces of the first valid option. That should be the first line after 'OPTIONS' starting with at least one space ending in '-'