fix: assign success status when displaying help usage via -h or -help - #25
Open
KristijanZic wants to merge 1 commit into
Open
fix: assign success status when displaying help usage via -h or -help#25KristijanZic wants to merge 1 commit into
KristijanZic wants to merge 1 commit into
Conversation
Added success status assignment before exiting help usage when invoked via -h or --help. In environments with set -e -o pipefail returning a non-zero exit code like -1 or (255 when -1 gets wrapped around to the maximum unsigned 8-bit value) results in help tests invocations failing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added success status assignment before exiting help usage when invoked via -h or --help.
In environments with
set -e -o pipefailreturning a non-zero exit code like -1 or (255 when -1 gets wrapped around to the maximum unsigned 8-bit value) results in help tests invocations failing.