fix: Tempo proxy fails when browser advertises unsupported encodings#908
Open
andreasgerstmayr wants to merge 3 commits into
Open
fix: Tempo proxy fails when browser advertises unsupported encodings#908andreasgerstmayr wants to merge 3 commits into
andreasgerstmayr wants to merge 3 commits into
Conversation
…(e.g. zstd) Previously, the reverse proxy forwarded the browser's Accept-Encoding header to Tempo. If the browser advertised an encoding we couldn't decompress (e.g. zstd), the response arrived in that encoding and our ModifyResponse handlers failed to read it. Now we clear Accept-Encoding before the request reaches Tempo and let gzhttp.Transport set only the encodings it can transparently decompress, removing the manual gzip/deflate decompression in ModifyResponse handlers. Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>
pavolloffay
previously approved these changes
Jun 23, 2026
Member
|
The CI failed |
Contributor
Author
Can you restart it? |
pavolloffay
reviewed
Jun 24, 2026
Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the reverse proxy forwarded the browser's Accept-Encoding header to Tempo. If the browser advertised an encoding we couldn't decompress (e.g. zstd), the response arrived in that encoding and our ModifyResponse handlers failed to read it.
Now we let gzhttp.Transport set only the encodings it can transparently decompress, removing the manual gzip/deflate decompression in ModifyResponse handlers.