Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
cms-cms
force-pushed
the
codex/embedded-fulltext-stability
branch
from
September 17, 2026 13:03
700adaf to
4a5d0d0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The deterministic synthetic corpus is not the original SciFact benchmark. The first-pass test uses supplied 8-dimensional embeddings. The scan/freeze case preloads 24,515 documents, runs eight scanning connections, inserts 32 rows per freeze round, and requests MINOR FREEZE every 120ms for 75 seconds.
Native embedded comparison
These results used test snapshot
abab612eab3d41a8be289fc12f67be68959ae32e, bindings5e8eece63205dccfa9500f98893c91d1f50eb4f1, old SeekDBdc88204e55100056acbfd64e213cd1ac2a256cd9and fixed SeekDB8a8d6f5a8dd48cdbf859305b3f7eb050149a5bd1(includes #1384).The actual embedded client was used, not a server endpoint or mock. Original conditional backend/version skips were retained.
Evidence boundaries and other results
end_stmt/send_error_packetrecords returning-4016. Memtable release/read-barrier messages are present, but the complete original issue's data/schema-mismatch → memtable-iterator → block-stat chain was not recovered. The error code alone is not proof of an identical kernel stack.OperationalError(4016, 'Internal error'). Uploading the oversized full-database artifact failed with HTTP 413. Raw server logs and the other 66 individual error records are therefore not verified; do not label every error as confirmed 4016 or claim a matched server stack.Diagnostic follow-up validation (before the CI source-wheel change)
The follow-up changes only diagnostics and fake-client unit scheduling, not the real SQL, workload duration, data, or failure assertions:
This is a regression test addition, not a database fix. A finite fixed-version pass does not prove that every timing interleaving is eliminated.
GitHub CI source-wheel correction
The previous GitHub run 35204502666 installed the released
pylibseekdb 1.3.0fromuv.lock, not the source-built fixed wheel used above. It correctly failed both new tests: one explicit 4016 in the first pass and 72 scan errors, with the first scan error explicitly 4016. These failures are not hidden or reclassified as success.Commit
4a5d0d0c4f2f2c0d5fb37daa934a38097ff5165badds a pinned source build inside the existing embedded job (no extra preflight job). The kernel and bindings use the same exact fixed revisions listed above. A native Ubuntu 22.04 / CPython 3.11 wheel is cached by source pins and build recipe, checked against wheel/binary SHA-256 and full REVISION, and verified after installation. Tests and examples useuv run --no-syncto prevent replacement by the released wheel. All embedded test assertions remain intact. Other jobs retain the existing dependency lock. This CI-local wheel is not a PyPI release or a portable manylinux package.The failed quality check was Ruff 0.14.11 formatting; the source now matches that version. Local validation: all 165 Python files pass Ruff check/format; 33 focused unit/contract tests pass; Bash syntax, actionlint 1.7.12 and uv 0.9.22 locked resolution pass. The latest GitHub run 35224727865 has passed quality; embedded source build/full integration validation is still pending. This does not replace the pending internal full-suite/artifact-collector follow-up.
All PR commit authors and committers are now
cms-cms; the accidentally machine-attributed diagnostic commit was corrected without changing its code tree. CLA status is being rechecked. Keep this PR draft until the new CI results are established.