Skip to content

surap - Technical Training - #1418

Open
srapyx wants to merge 34 commits into
odoo:19.0from
odoo-dev:19.0-tuto-surap
Open

srapyx wants to merge 34 commits into
odoo:19.0from
odoo-dev:19.0-tuto-surap

Conversation

@srapyx

@srapyx srapyx commented Sep 15, 2026

Copy link
Copy Markdown

Chapter 5

@robodoo

robodoo commented Sep 15, 2026

Copy link
Copy Markdown

Pull request status dashboard

		import
	modified:   estate/__manifest__.py
		import
	new file:   estate/data/.gitkeep
	new file:   estate/models/__init__.py
		creation + import
	new file:   estate/models/estate_property.py
		define model
	modified:   estate/models/estate_property.py
		try to fix weird basedpylance error
			Argument of type "list[tuple[str, str]]" cannot be assigned to parameter "selection" of type "Sentinel" in function "__init__"
			  "list[tuple[str, str]]" is not assignable to "Sentinel"
	new file:   estate/security/ir.model.access.csv
		defining acces

@leclerc-leo leclerc-leo left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Good Work
It's better to have a PR content that's a bit more explicit than check.

Comment thread estate/models/__init__.py Outdated
@@ -0,0 +1 @@
from . import estate_property No newline at end of file

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We try to always have an empty line at the end of every file.
You can use the Ruff extension with the config from https://runbot211.odoo.com/runbot/static/build/125366383-19-0/logs/ruff_config.txt to have warning about style inside your editor.
Disable auto formatting on save as we try to reduce the quantity of diff when editing file made by someone else
You can also check the ci/style from the runbot (https://runbot.odoo.com/runbot/bundle/190-tuto-surap-512658) to check what it says.

Comment thread estate/models/estate_property.py
Comment thread estate/data/.gitkeep Outdated

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's best not to push .gitkee, pycache, ...

Comment thread estate/models/estate_property.py Outdated
srapyx and others added 20 commits September 16, 2026 11:05
	modified:   estate/__manifest__.py
		ref view
	new file:   estate/views/estate_property_views.xml
		basic view
	modified:   estate/__manifest__.py
		ref menu
	new file:   estate/views/estate_menus.xml
	modified:   estate/views/estate_property_views.xml
		fix
Co-authored-by: Leclerc Léo (leol) <74907637+leclerc-leo@users.noreply.github.com>
Co-authored-by: Leclerc Léo (leol) <74907637+leclerc-leo@users.noreply.github.com>
	deleted:    estate/data/.gitkeep
	modified:   estate/__init__.py
	modified:   estate/models/__init__.py
	modified:   estate/security/ir.model.access.csv
	modified:   estate/views/estate_menus.xml
	modified:   estate/views/estate_property_views.xml
	modified:   estate/views/estate_menus.xml
	modified:   estate/views/estate_property_views.xml
	modified:   estate/models/estate_property.py
		add state
	modified:   estate/views/estate_property_views.xml
		-> same fix as previous commit
(group by ok)
	modified:   estate/views/estate_property_views.xml
	modified:   __manifest__.py
	modified:   models/__init__.py
	new file:   models/estate_property_type.py
	modified:   security/ir.model.access.csv
	modified:   views/estate_menus.xml
	new file:   views/estate_property_type_views.xml
	modified:   models/estate_property.py
	modified:   views/estate_property_type_views.xml
	modified:   views/estate_property_views.xml
	modified:   models/estate_property.py
	modified:   views/estate_property_views.xml
	modified:   __manifest__.py
	modified:   models/__init__.py
	modified:   models/estate_property.py
	new file:   models/estate_property_tag.py
	modified:   security/ir.model.access.csv
	modified:   views/estate_menus.xml
	new file:   views/estate_property_tag_views.xml
	modified:   views/estate_property_views.xml
	modified:   estate/__manifest__.py
	modified:   estate/models/__init__.py
	modified:   estate/models/estate_property.py
	new file:   estate/models/estate_property_offer.py
	modified:   estate/security/ir.model.access.csv
	new file:   estate/views/estate_property_offer_views.xml
	modified:   estate/views/estate_property_views.xml
8.1 - totalarea
	modified:   estate/models/estate_property.py
	modified:   estate/views/estate_property_views.xml
	modified:   estate/models/estate_property.py
	modified:   estate/views/estate_property_views.xml
	modified:   estate/models/estate_property_offer.py
	modified:   estate/views/estate_property_offer_views.xml
	modified:   estate/models/estate_property.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants