Conversation
|
|
added 11 commits
September 15, 2026 14:20
…mize 'selection' in manifest
[IMP] estate_property model: adding Active and Status fields
leclerc-leo
reviewed
Sep 16, 2026
|
|
||
| # Pyre type checker | ||
| .pyre/ | ||
| .idea No newline at end of file |
There was a problem hiding this comment.
Try not to push changes to .gitignore, you can add a .gitignore in the folder that contains tutorials, odoo (community) and enterprise folder instead and it should still register.
If you only have tutorial opened, you should probably open a folder that contains those 3 folders as you can use it to search in the odoo/enterprise codebase for example which will help greatly later.
| name = fields.Char('Name', required=True) | ||
| description = fields.Text('Description') | ||
| postcode = fields.Char('Postcode') | ||
| date_availability = fields.Date('Availability Date', copy=False, default=lambda self: fields.Date.add(fields.Date.today(), days=90)) |
There was a problem hiding this comment.
We try to keep the lines around ~120 characters. If you use vscode you can configure the settings for rulers to add one there.
Nitpick: some people like to have string= before the string to make it clearer.
Suggested change
| date_availability = fields.Date('Availability Date', copy=False, default=lambda self: fields.Date.add(fields.Date.today(), days=90)) | |
| date_availability = fields.Date( | |
| string='Availability Date', | |
| copy=False, | |
| default=lambda self: fields.Date.add(fields.Date.today(), days=90)< | |
| ) |
Comment on lines
+22
to
+26
| selection=[ | ||
| ("north", "North"), | ||
| ("south", "South"), | ||
| ("east", "East"), | ||
| ("west", "West")], |
There was a problem hiding this comment.
nitpick
Suggested change
| selection=[ | |
| ("north", "North"), | |
| ("south", "South"), | |
| ("east", "East"), | |
| ("west", "West")], | |
| selection=[ | |
| ("north", "North"), | |
| ("south", "South"), | |
| ("east", "East"), | |
| ("west", "West"), | |
| ], |
added 15 commits
September 16, 2026 11:35
[FIX] estate_property : nitpick adjustments [MOV] menu items from estate_view to estate_menu
[FIX] estate_property model : fields label changed
- creating model - adding it to the security group - updating the menu - creating a view - updating the __init__.py and __manifest__.py
- creating model - adding it to the security group - creating the form view - updating __init__.py and __manifest__.py
- adding offer One2Many offer field - adding a offer's list view
- adding total area field + updating form view
aboo-odoo
self-requested a review
September 17, 2026 12:49
|
Hey 👋 I'll be managing your review now to spread the load among the 4 of us 😄 |
added 2 commits
September 17, 2026 15:49
…den area, garden orientation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[ADD] '.idea' to gitignore