19.0 technical training jever - #1429
JeromeVerkyndt wants to merge 6 commits into
Conversation
|
|
lost-odoo
left a comment
lost-odoo
left a comment
There was a problem hiding this comment.
Hi I already did a small review, overall it's good just minor things. I always made one comment for a specific issue but it applies for the whole pull request.
So for instance the final newline occurs at multiple places.
Good Job :D
| @@ -0,0 +1,3 @@ | |||
| # -*- coding: utf-8 -*- | |||
There was a problem hiding this comment.
Hi do not forget to follow those Git guidelines when doing you commit messages
| @@ -0,0 +1,3 @@ | |||
| # -*- coding: utf-8 -*- | |||
|
|
|||
| from . import estate_property No newline at end of file | |||
There was a problem hiding this comment.
Missing final new line at end of file
| @@ -0,0 +1,3 @@ | |||
| # -*- coding: utf-8 -*- | |||
There was a problem hiding this comment.
# -*- coding: utf-8 -*- not needed anymore
| class Property(models.Model): | ||
| _name = "estate.property" | ||
| _description = "Estate property model" | ||
|
|
There was a problem hiding this comment.
Do not forget to make you runbot green, here ci/style would complain
| name = fields.Char(required=True) | ||
| description = fields.Text() | ||
| postcode = fields.Char() | ||
| date_availability = fields.Date(copy=False, default=date.today()+ timedelta(days=90)) |
There was a problem hiding this comment.
You should use a lambda here for your default parameter otherwise, it would be fixed from the server start. Using a lambda here would be dynamic at creation.
…ameter and code formatting.
3 participants
No description provided.