Improve local only sync#87
Open
opatry wants to merge 21 commits into
Open
Conversation
Contributor
Job Summary for GradleBuild & Test :: build
|
opatry
force-pushed
the
improve-local-only-sync
branch
from
October 30, 2024 16:21
a215d01 to
2fa07e3
Compare
Contributor
Job Summary for GradleBuild & Test :: build |
opatry
force-pushed
the
improve-local-only-sync
branch
from
October 30, 2024 17:16
2fa07e3 to
205612f
Compare
opatry
commented
Oct 30, 2024
| } | ||
| if (remoteTaskList != null) { | ||
| taskListDao.upsert(remoteTaskList.asTaskListEntity(localTaskList.id, localTaskList.sorting)) | ||
| taskListIds[localTaskList.id] = remoteTaskList.id |
Owner
Author
There was a problem hiding this comment.
This isn't ideal for the next step as it would consider this local only list as remote from now on.
In particular, it will query its tasks which aren't there for sure…
This should be refactored another way.
opatry
force-pushed
the
improve-local-only-sync
branch
2 times, most recently
from
November 5, 2024 07:33
f674a02 to
5412239
Compare
opatry
force-pushed
the
improve-local-only-sync
branch
from
November 30, 2024 08:43
5412239 to
ac610fa
Compare
opatry
force-pushed
the
improve-local-only-sync
branch
from
April 24, 2025 18:08
ac610fa to
7ed297d
Compare
Contributor
©️ Stale credits for
|
opatry
force-pushed
the
improve-local-only-sync
branch
3 times, most recently
from
May 15, 2025 21:56
5e9d88d to
7148451
Compare
opatry
force-pushed
the
improve-local-only-sync
branch
4 times, most recently
from
May 24, 2025 21:04
45c682b to
66816d0
Compare
opatry
force-pushed
the
improve-local-only-sync
branch
from
May 31, 2025 08:46
66816d0 to
d38d62f
Compare
4 tasks
opatry
force-pushed
the
improve-local-only-sync
branch
2 times, most recently
from
June 1, 2025 21:39
179fe03 to
c6677a7
Compare
… later when its appropriate)
…s to minimize sync to DB work
opatry
force-pushed
the
improve-local-only-sync
branch
from
June 2, 2025 20:48
c6677a7 to
6b0836b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
updateMinto only sync tasks updated since last syncTODO
Checklist