perf: empty default for ProviderEvaluation#1970
Conversation
Signed-off-by: Tobias Ibounig <tobias.ibounig@dynatrace.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughIn ChangesDefault flagMetadata initialization
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1970 +/- ##
============================================
+ Coverage 92.11% 93.10% +0.98%
- Complexity 660 663 +3
============================================
Files 59 59
Lines 1624 1624
Branches 182 182
============================================
+ Hits 1496 1512 +16
+ Misses 80 66 -14
+ Partials 48 46 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|



This PR
ImmutableMetadata.EMPTYsingleton as the default value forProviderEvaluation.flagMetadataRelated Issues
None
Notes
Every
ProviderEvaluationbuilt without explicit metadata allocated a fresh emptyImmutableMetadatainstance via@Builder.Default. Reusing the existingImmutableMetadata.EMPTYsingleton is safe because the class has no mutation methods, andFlagEvaluationDetailsalready uses the same singleton as its default.benchmark.txtmainmainrun:+totalAllocatedBytesrun:+totalAllocatedInstancesFollow-up Tasks
benchmark.txtafter all are appliedSummary by CodeRabbit
Release Notes
This release includes internal optimizations with no user-facing changes.