fix(ui): prevent schedule column text from wrapping mid-word in pipeline table#30205
Merged
ShaileshParmar11 merged 3 commits intoJul 20, 2026
Conversation
…ine table
The Schedule cell in the ingestion/test-suite pipeline table rendered its
text inside a `wrap={false}` flex row where the text column shrinks, causing
"At 12:00 AM" / "Every day" to break character-by-character. Add
`whitespace-nowrap` to both schedule detail lines so each stays on a single
line within the fixed-width column.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
❌ PR checklist incompleteThis PR cannot be merged until the following are addressed on its linked issue:
The fields live on the linked issue in the Shipping project (open the issue → right sidebar → Projects). After you set them, re-run this check (or push a commit) — issue/project changes do not re-trigger it automatically. Maintainers can bypass this check by adding the |
github-actions
Bot
added
safe to test
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
Jest test CoverageUI tests summary
|
… overflowing Addresses review feedback: whitespace-nowrap alone prevents the mid-word break but lets long verbose cron descriptions (e.g. "On day 1 of the month, only in January") expand the auto-layout column and overflow the 150–176px Schedule cell. Replace the plain nowrap with antd Typography ellipsis + tooltip in ScheduleFieldCell (min-w-0 flex column so it can shrink), and cap the schedule cell width at both call sites (tw:max-w-44 on the core-components cell, maxWidth onCell on the antd column) so ellipsis engages. Short schedules render on one line each; long ones truncate with the full text available on hover. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
🟡 Playwright Results — all passed (31 flaky)✅ 4540 passed · ❌ 0 failed · 🟡 31 flaky · ⏭️ 95 skipped
🟡 31 flaky test(s) (passed on retry)
How to debug locally# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip # view trace |
The shared Table wrapper renders antd with tableLayout="fixed", so the column's width: 150 is already a hard cap via colgroup and the inner ellipsis engages without any extra max-width. Verified: fixed layout with colgroup width:150 yields identical results with and without max-width (cell 150px, ellipsis engaged). The core-components table in TestSuitePipelineTab is table-layout: auto, so it still needs both tw:w-44 (holds the target width) and tw:max-w-44 (prevents content-driven growth). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
chirag-madlani
approved these changes
Jul 20, 2026
Code Review ✅ ApprovedPrevents mid-word line wrapping and layout overflow in the pipeline table by constraining column widths and enabling ellipsis truncation for schedule descriptions. No issues found. OptionsDisplay: compact → Showing less information. Comment with these commands to change the behavior for this request:
Was this helpful? React with 👍 / 👎 | Gitar |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
issue
fix
Problem
In the pipeline table (test-suite Data Observability tab and the ingestion list table), the Schedule column text broke character-by-character — e.g. "At 12:00 AM" rendered as "At 12:", "00", "AM" stacked vertically.
The schedule cell renders its two text lines inside a
wrap={false}Ant Design flex row. Withwrap={false}, the flex items don't wrap but the text column still shrinks below its content width, so the text itself wrapped mid-word.Fix
Add
whitespace-nowrapto both schedule detail lines (schedule-primary-detailsandschedule-secondary-details) inScheduleFieldCellso each stays on a single line within the fixed-width column.Verification
whiteSpace: nowrapand render on a single line (85px and 56px wide, inside the 176px column).Before
"At 12:" / "00" / "AM" wrapping vertically in the Schedule column.
After
"At 12:00 AM" / "Every day" — clean two-line layout, no mid-word breaks.
🤖 Generated with Claude Code
Summary by Gitar
TestSuitePipelineTabandIngestionListTableto prevent layout breaking.flex="auto"andtw:min-w-0to schedule column containers to ensure proper truncation behavior.whitespace-nowrapwithellipsison schedule details to safely handle long descriptions.This will update automatically on new commits.
Greptile Summary
This PR improves Schedule column rendering in pipeline tables. The main changes are:
Confidence Score: 5/5
This looks safe to merge.
Important Files Changed
Reviews (3): Last reviewed commit: "fix(ui): drop redundant maxWidth onCell ..." | Re-trigger Greptile
Context used (3)