MINOR - Fix CI on fork by TeddyCr · Pull Request #30255 · open-metadata/OpenMetadata

TeddyCr · 2026-07-20T22:42:44Z

Describe your changes:

remove merge_commit_sha to allow fork PR to run checks. Instead rely on merge queue to test the changes against the latest from main. This prevents triggering the checkout guards

Type of change:

High-level design:

N/A — small change.

Tests:

Use cases covered

Unit tests

Backend integration tests

Ingestion integration tests

Playwright (UI) tests

Manual testing performed

UI screen recording / screenshots:

Not applicable.

Checklist:

I have read the CONTRIBUTING document.
My PR title is Fixes <issue-number>: <short explanation>
My PR is linked to a GitHub issue via Fixes #<issue-number> above.
I have commented on my code, particularly in hard-to-understand areas.
For JSON Schema changes: I updated the migration scripts or explained why it is not needed.
For UI changes: I attached a screen recording and/or screenshots above.
I have added tests (unit / integration / Playwright as applicable) and listed them above.

Summary by Gitar

CI configuration:
- Updated actions/checkout ref logic across multiple workflow files to support GitHub merge groups.
- Synchronized SOURCE_SHA environment variable to ensure consistency with the checkout ref in build steps.

_{This will update automatically on new commits.}

Greptile Summary

This PR updates CI revision selection and expands merge-queue coverage. The main changes are:

Checkout pull-request head commits instead of synthetic merge commits.
Use merge-group SHAs for queued revisions.
Add merge-group triggers to several Playwright workflows.
Align reported source SHAs with the selected checkout.

Confidence Score: 4/5

Existing push and manual CI paths can receive empty revision values and need fixes before merging.

Merge-group events select the intended queue SHA.
Push events in the integration workflows lose both checkout and artifact SHAs.
Manual runs across several workflows lose their checkout ref.

The changed integration, Playwright, and Python workflows that use the two-branch SHA expression.

Important Files Changed

Filename	Overview
.github/workflows/integration-tests-mysql-elasticsearch.yml	The new SHA expression works for PR and merge-group events but becomes empty on push and manual runs.
.github/workflows/integration-tests-postgres-elasticsearch-redis.yml	The checkout and artifact source SHA become empty on existing push and manual triggers.
.github/workflows/integration-tests-postgres-opensearch.yml	The checkout and artifact source SHA become empty on existing push and manual triggers.
.github/workflows/playwright-mysql-e2e.yml	Merge-group checkout is supported, but manual dispatch no longer supplies a valid ref.
.github/workflows/playwright-postgresql-e2e.yml	The changed checkout works for PR and merge-group events but not manual dispatch.
.github/workflows/playwright-sso-tests.yml	Merge-group support is added, while manual dispatch can produce empty checkout and reporting SHAs.
.github/workflows/py-tests.yml	The changed checkout expressions do not preserve a valid SHA for manual runs.
.github/workflows/py-tests-postgres.yml	The changed checkout expression does not preserve a valid SHA for manual runs.

_{Reviews (1): Last reviewed commit: "fix: reverted checkout + enabled merge g..." | Re-trigger Greptile}

Greptile also left 2 inline comments on this PR.

Context used (3)

Context used - CLAUDE.md (source)
Context used - openmetadata-ui-core-components/CLAUDE.md (source)
Context used - AGENTS.md (source)

github-actions · 2026-07-20T22:42:53Z

❌ PR checklist incomplete

This PR cannot be merged until the following are addressed on its linked issue:

No GitHub issue is linked. Link an issue in the Development section of the PR (or add Fixes #12345 to the description). For a same-org cross-repo issue, add Fixes open-metadata/<repo>#123 to the description.

The fields live on the linked issue in the Shipping project (open the issue → right sidebar → Projects). After you set them, re-run this check (or push a commit) — issue/project changes do not re-trigger it automatically.

Maintainers can bypass this check by adding the skip-pr-checks label.

github-actions · 2026-07-20T22:43:28Z

🔴 Playwright Results — 4 pipeline/setup failure(s)

✅ 0 passed · ❌ 0 failed · 🟡 0 flaky · ⏭️ 0 skipped

Pipeline and setup failures

The build job finished with status failure.
Shard detection finished with status failure.
The Playwright shard matrix was unexpectedly skipped.
No expected Playwright shards were declared.

Shard	Passed	Failed	Flaky	Skipped

📦 Download artifacts

How to debug locally

# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip    # view trace

gitar-bot · 2026-07-20T22:44:40Z

Code Review ✅ Approved

Updates CI checkout configuration to enable GitHub merge groups and adds support for unsafe PR checkouts. No issues found.

Options

Display: compact → Showing less information.

Comment with these commands to change the behavior for this request:

`Compact`
`gitar display:verbose`

_{Was this helpful? React with 👍 / 👎 | Gitar}

greptile-apps · 2026-07-20T22:45:42Z

        uses: actions/checkout@v4
        with:
-          ref: ${{ github.event_name == 'pull_request_target' && github.event.pull_request.merge_commit_sha || github.sha }}
+          ref: ${{ github.event_name == 'merge_group' && github.sha || github.event.pull_request.head.sha }}


Manual Runs Lose Checkout Ref

A workflow_dispatch event has no pull_request.head.sha, so this checkout receives an empty ref instead of the dispatched revision. The run can fail at checkout or test the default branch rather than the requested code. The changed PostgreSQL E2E, SSO, and Python test workflows use the same expression on their manual-run paths.

Copilot

Pull request overview

This PR updates several GitHub Actions workflows to better support GitHub Merge Queue (merge_group) and to keep the SOURCE_SHA/checkout ref consistent across CI jobs.

Changes:

Added merge_group triggers to selected workflows.
Updated actions/checkout ref: logic across multiple workflows.
Updated SOURCE_SHA in Playwright/integration workflows to match the intended tested SHA.

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 18 comments.

Show a summary per file

File	Description
.github/workflows/py-tests.yml	Updates checkout ref selection for Python CI jobs.
.github/workflows/py-tests-postgres.yml	Updates checkout ref selection for Python Postgres CI.
.github/workflows/playwright-sso-tests.yml	Adds `merge_group` trigger and updates checkout/SOURCE_SHA.
.github/workflows/playwright-postgresql-e2e.yml	Updates checkout/SOURCE_SHA used by Playwright Postgres E2E flow.
.github/workflows/playwright-mysql-e2e.yml	Adds `merge_group` trigger and updates checkout ref.
.github/workflows/playwright-integration-tests-postgres.yml	Adds `merge_group` trigger and updates checkout ref.
.github/workflows/playwright-integration-tests-mysql.yml	Adds `merge_group` trigger and updates checkout ref.
.github/workflows/integration-tests-postgres-opensearch.yml	Updates checkout/SOURCE_SHA used by Java integration tests (PG+OS).
.github/workflows/integration-tests-postgres-elasticsearch-redis.yml	Updates checkout/SOURCE_SHA used by Java integration tests (PG+ES+Redis).
.github/workflows/integration-tests-mysql-elasticsearch.yml	Updates checkout/SOURCE_SHA used by Java integration tests (MySQL+ES).

        uses: actions/checkout@v4
        with:
-          ref: ${{ github.event_name == 'pull_request_target' && github.event.pull_request.merge_commit_sha || github.sha }}
+          ref: ${{ github.event_name == 'merge_group' && github.sha || github.event.pull_request.head.sha }}


        uses: actions/checkout@v4
        with:
-          ref: ${{ github.event_name == 'pull_request_target' && github.event.pull_request.merge_commit_sha || github.sha }}
+          ref: ${{ github.event_name == 'merge_group' && github.sha || github.event.pull_request.head.sha }}


        uses: actions/checkout@v4
        with:
-          ref: ${{ github.event_name == 'pull_request_target' && github.event.pull_request.merge_commit_sha || github.sha }}
+          ref: ${{ github.event_name == 'merge_group' && github.sha || github.event.pull_request.head.sha }}


        uses: actions/checkout@v4
        with:
-          ref: ${{ github.event_name == 'pull_request_target' && github.event.pull_request.merge_commit_sha || github.sha }}
+          ref: ${{ github.event_name == 'merge_group' && github.sha || github.event.pull_request.head.sha }}


        uses: actions/checkout@v4
        with:
-          ref: ${{ github.event_name == 'pull_request_target' && github.event.pull_request.merge_commit_sha || github.sha }}
+          ref: ${{ github.event_name == 'merge_group' && github.sha || github.event.pull_request.head.sha }}


        env:
          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-          SOURCE_SHA: ${{ github.event_name == 'pull_request_target' && github.event.pull_request.merge_commit_sha || github.sha }}
+          SOURCE_SHA: ${{ github.event_name == 'merge_group' && github.sha || github.event.pull_request.head.sha }}


        uses: actions/checkout@v4
        with:
-          ref: ${{ github.event_name == 'pull_request_target' && github.event.pull_request.merge_commit_sha || github.sha }}
+          ref: ${{ github.event_name == 'merge_group' && github.sha || github.event.pull_request.head.sha }}


        env:
          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-          SOURCE_SHA: ${{ github.event_name == 'pull_request_target' && github.event.pull_request.merge_commit_sha || github.sha }}
+          SOURCE_SHA: ${{ github.event_name == 'merge_group' && github.sha || github.event.pull_request.head.sha }}


TeddyCr · 2026-07-20T23:26:07Z

check https://github.com/open-metadata/OpenMetadata/pull/30255/changes#r3618187856 regarding copilot comments

TeddyCr added 2 commits July 20, 2026 14:59

fix: allow allow-unsafe-pr-checkout

f086642

fix: reverted checkout + enabled merge group

2661091

Copilot AI review requested due to automatic review settings July 20, 2026 22:42

TeddyCr requested review from akash-jain-10, harshach and tutte as code owners July 20, 2026 22:42

github-actions Bot added Ingestion safe to test Add this label to run secure Github workflows on PRs labels Jul 20, 2026

Copilot started reviewing on behalf of TeddyCr July 20, 2026 22:43 View session

greptile-apps Bot reviewed Jul 20, 2026

View reviewed changes

Copilot AI reviewed Jul 20, 2026

View reviewed changes

TeddyCr changed the title ~~Minor ci on fork~~ MINOR - Fix CI on fork Jul 20, 2026

TeddyCr added the skip-pr-checks Bypass PR metadata validation check label Jul 20, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

MINOR - Fix CI on fork#30255

MINOR - Fix CI on fork#30255
TeddyCr wants to merge 2 commits into
open-metadata:mainfrom
TeddyCr:MINOR-CI-On-fork

TeddyCr commented Jul 20, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Jul 20, 2026

Uh oh!

github-actions Bot commented Jul 20, 2026

Uh oh!

gitar-bot Bot commented Jul 20, 2026

Uh oh!

Uh oh!

greptile-apps Bot Jul 20, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

TeddyCr commented Jul 20, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

TeddyCr commented Jul 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Describe your changes:

Type of change:

High-level design:

Tests:

Use cases covered

Unit tests

Backend integration tests

Ingestion integration tests

Playwright (UI) tests

Manual testing performed

UI screen recording / screenshots:

Checklist:

Summary by Gitar

Greptile Summary

Confidence Score: 4/5

Important Files Changed

Context used (3)

Uh oh!

github-actions Bot commented Jul 20, 2026

❌ PR checklist incomplete

Uh oh!

github-actions Bot commented Jul 20, 2026

🔴 Playwright Results — 4 pipeline/setup failure(s)

Pipeline and setup failures

Uh oh!

gitar-bot Bot commented Jul 20, 2026

Uh oh!

Uh oh!

greptile-apps Bot Jul 20, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

TeddyCr commented Jul 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

TeddyCr commented Jul 20, 2026 •

edited

Loading

TeddyCr commented Jul 20, 2026 •

edited

Loading