Conversation
Signed-off-by: Cristiano Gavião <cvgaviao@gmail.com>
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The change is a small, additive, backwards-compatible schema extension that matches the linked issue’s request.
Review effort: Lite
Findings: None
What changed in this PR
This PR updates the workflow JSON Schema to support specifying a working directory for RunShell, addressing issue #1191 so shell commands can execute with an explicit working directory rather than inheriting the workflow application’s startup directory.
Changes:
- Adds an optional
directorystring property to theRunShell.shellconfiguration object. - Documents the new property as the working directory used when running the shell command.
| File | Description |
|---|---|
| schema/workflow.yaml | Extends the RunShell schema to allow an optional working-directory (directory) for shell execution. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please specify parts of this PR update:
#1191
What this PR does:
Added property directory to RunShell
Additional information: