Skip to content

Feat/mailgun newsletter#982

Open
jona159 wants to merge 27 commits into
devfrom
feat/mailgun-newsletter
Open

Feat/mailgun newsletter#982
jona159 wants to merge 27 commits into
devfrom
feat/mailgun-newsletter

Conversation

@jona159

@jona159 jona159 commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Type of Change

  • Dependency upgrade
  • Bug fix (non-breaking change)
  • Breaking change
    • e.g. a fixed bug or new feature that may break something else
  • New feature
  • Code quality improvements
    • e.g. refactoring, documentation, tests, tooling, ...

Implementation

Checklist

  • I gave this pull request a meaningful title
  • My pull request is targeting the dev branch
  • I have added documentation to my code
  • I have deleted code that I have commented out

Additional Information

  • This PR closes #

@github-actions

github-actions Bot commented Jun 16, 2026

Copy link
Copy Markdown

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 67.75% 2152 / 3176
🔵 Statements 66.22% 2222 / 3355
🔵 Functions 65.42% 422 / 645
🔵 Branches 51.86% 1029 / 1984
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
app/db/models/token.server.ts 55.55% 100% 42.85% 52.94% 41-84
app/db/models/user.server.ts 57.62% 33.33% 62.5% 57.62% 29-40, 74, 133-224, 293
app/db/schema/action-token.ts 83.33% 100% 75% 80% 22
app/db/schema/user.ts 80% 100% 66.66% 75% 37
app/emails/newsletter-confirmation.tsx 75% 20% 0% 75% 61-106
app/lib/request-parsing.ts 85.29% 61.66% 100% 85.29% 36, 122-128, 137, 155, 202, 212-217, 242-246
app/lib/openapi/schemas/user.ts 100% 100% 100% 100%
app/routes/api.users.me.ts 83.09% 78.04% 100% 85.5% 92-96, 273, 276, 302, 308, 322, 341, 364, 379, 384, 402, 413
app/routes/api.users.register.ts 75% 47.61% 100% 75% 142-144, 150, 155, 166, 209, 214-225
app/services/newsletter-service.server.ts 2.94% 0% 0% 3.27% 38-50, 54-255
app/services/user-service.server.ts 68.78% 62.4% 66.66% 71.02% 109-113, 151-155, 171-175, 187-190, 210-211, 259-267, 295-301, 306-312, 316-322, 335-337, 377-388, 462-510, 524, 574-602, 615, 662, 668, 670
Generated in workflow #2714 for commit c852a28 by the Vitest Coverage Report Action

@jona159 jona159 linked an issue Jun 16, 2026 that may be closed by this pull request
@jona159 jona159 marked this pull request as ready for review June 16, 2026 14:01

if (
!signingKey ||
!signature?.timestamp ||

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just for clarification: Check for presence of signature and signature.timestamp rolled into one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

transactional emails subscription option

2 participants