Feat/add home coordinates

[jona159]

Type of Change

• Dependency upgrade
• Bug fix (non-breaking change)
• Breaking change
  • e.g. a fixed bug or new feature that may break something else
• New feature
• Code quality improvements
  • e.g. refactoring, documentation, tests, tooling, ...

Implementation

Checklist

• I gave this pull request a meaningful title
• My pull request is targeting the dev branch
• I have added documentation to my code
• I have deleted code that I have commented out

Additional Information

• This PR closes add home coordinates #992

[github-actions]

Coverage Report

Status	Category	Percentage	Covered / Total
🔵	Lines	69.41%	2136 / 3077
🔵	Statements	67.89%	2206 / 3249
🔵	Functions	67.46%	421 / 624
🔵	Branches	52.98%	1021 / 1927

File Coverage

File	Stmts	Branches	Functions	Lines	Uncovered Lines
Changed Files
app/db/models/device.server.ts	63.59%	67%	60.46%	64%	86-91, 99, 151-152, 221-236, 276, 310, 339, 368, 398, 402, 410-412, 418-420, 438-440, 444-446, 488-490, 505-659, 710-714, 742-748, 753-769, 848-850, 861, 868-869, 877, 904, 1006-1026, 1045
app/db/models/profile.server.ts	2.63%	0%	7.69%	3.22%	15-69, 91-125
app/db/schema/profile.ts	80%	100%	66.66%	75%	33
app/lib/location.ts	16.66%	12.19%	16.66%	17.39%	28, 32, 44-65, 88-253

Generated in workflow #2710 for commit e3d09c5 by the Vitest Coverage Report Action

[zven]

Zooming in on 0 0 when the user is logged in and nothing is set at all is not the best idea. How about showing the "old" globe view with Münster as a center in that case? That's the one that is alos shown, when no user is logged in right?

---

Update:

The map only zooms to that location when I am in a menu and then click the osem icon on the upper left:

[zven]

Another update: When simply accessing http://localhost:3000/ I am also redirected to http://localhost:3000/explore#10/0/0

[zven]

Home location is set do some default (see right) but the map home button (left) still brings me to 0 0

[zven]

The coordinates and zoom level seem to be hardcoded (see screenshot below). On the other hand, the menu says that I can leave it empty to use my own devices as a home area. How do I do that if the default after clicking Clear home location is hardcoded values?

[zven]

As soon as I have set a home area, the logo icon button works for zooming in. Not having set an area seems to be the problem.

[jona159]

Zooming in on 0 0 when the user is logged in and nothing is set at all is not the best idea. How about showing the "old" globe view with Münster as a center in that case? That's the one that is alos shown, when no user is logged in right?

Update:

The map only zooms to that location when I am in a menu and then click the osem icon on the upper left:

There was a bug in the calculation of the area that spans the user's devices, that should be fixed now. By default if nothing is set the button should zoom to the area that covers the user's devices or if they dont have any it should default to the initial view state (münster coordinates at zoom level 2)

[jona159]

The coordinates and zoom level seem to be hardcoded (see screenshot below). On the other hand, the menu says that I can leave it empty to use my own devices as a home area. How do I do that if the default after clicking Clear home location is hardcoded values?

The values for latitude and longitude here are just placeholders, do you think they should be removed to avoid confusion?

[jona159]

Another update: When simply accessing http://localhost:3000/ I am also redirected to http://localhost:3000/explore#10/0/0

As we made the map view our landing page we redirect from the index route to the explore route, on which again we by default zoom to either the initial view state (not logged in or no devices), the calculated area for the user's devices (no home view set) or the home view from the settings

[zven]

Default location for adding a new device is currently set to 0 0 but the user has to zoom out and find the marker. Any more elegant ideas? ;-)

[zven]

When I only adjust the zoom level (or delete the initial 10 the saving indicator flickers between Saving... and Unsaved changes. This does not happen for the coordinates.

[jona159]

When I only adjust the zoom level (or delete the initial 10 the saving indicator flickers between Saving... and Unsaved changes. This does not happen for the coordinates.

The poblem was with trying to save a zoom level without coordinates, should be prevented now (zoom input field is disabled as long as coords are missing)