Match direct-child <br> and <em> in _stringify#133
Open
c-tonneslan wants to merge 1 commit into
Open
Conversation
Signed-off-by: c-tonneslan <cst0520@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_stringifyturns<br>inside a table cell into a newline (and marks<em>), but the XPath*//brexpands tochild::*/descendant-or-self::node()/br— it only matches a<br>nested inside a child element of the cell. A<br>that is a direct child of the<td>is never matched, so the newline isn't inserted and two logical lines get glued together..//brisdescendant-or-self::node()/br, a strict superset that also covers the nested case, so cells whose<br>sits inside a<font>/other wrapper (as in the current fixtures) behave exactly as before. Same fix for*//em→.//em.Added a parametrized test in
tests/test_parsing.pycovering both the direct-child and nested cases (the direct-child case fails on the current XPath).