Prevent unconnected ports from reporting oper status up - #732
Open
sreeiyer-1 wants to merge 2 commits into
Open
sreeiyer-1 wants to merge 2 commits into
sreeiyer-1 wants to merge 2 commits into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
sreeiyer-1
marked this pull request as ready for review
September 23, 2026 11:20
Contributor
|
/gcbrun |
Signed-off-by: Sree Iyer <sbiyer@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lucius creates fallback tap interfaces for ports whose kernel interfaces are absent. A later admin up is received for these interfaces can enable the tap interfaces and cause them to report The operational status as up. This can happen either at boot time or when the Ethernet interfaces is flapped.
Before processing the admin up request, check whether the eth interface derived from the first lane exists. If it is not present, ignore the admin request and leave the fallback port down. No change in the behaviour for connected ports and admin down requests.
In the test below, the topology used that 32 Ethernet interfaces with a breakout of 4. Only eth1 to eth16 are connected to a peer.
Ethernet48 below is an unconnected interface. The operational status follows admin status and shows as up :
After the changes :
Unit test
No change in the results of the other unit tests - GetSwitchStats continues to fail and all the other tests pass.