Restore cgroup namespace in ignore mode - #5418
Closed
TimDurward wants to merge 1 commit into
Closed
TimDurward wants to merge 1 commit into
TimDurward wants to merge 1 commit into
Conversation
kolyshkin
force-pushed
the
criu-ignore-cgroupns
branch
from
August 24, 2026 19:59
b531698 to
0e3ad85
Compare
Signed-off-by: Timothy Durward <timothy.a.durward@gmail.com>
kolyshkin
force-pushed
the
criu-ignore-cgroupns
branch
from
August 28, 2026 08:47
0e3ad85 to
185f256
Compare
kolyshkin
requested changes
Sep 9, 2026
Contributor
There was a problem hiding this comment.
@TimDurward thanks for the patch.
Мoving runc restore itself into container's cgroup temporarily feels like a bad thing to do.
(an older version of this comment suggested using SysProcAttr.UseCgroupFD/CLONE_INTO_CGROUP which is not the right solution)
Contributor
|
Being fixed in criu (checkpoint-restore/criu#3139) instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When restoring into a different cgroup with
--manage-cgroups-mode=ignore, the process is placed in the configured cgroup but its private cgroup namespace is not preserved./proc/self/cgroupconsequently exposes the host-relative cgroup path instead of0::/.This change keeps the restored process in a private cgroup namespace. The existing test for restoring into a new cgroup now checks that
/proc/self/cgroupstill reports0::/after restore.Fixes #5417