Conversation
kolyshkin
requested review from
AkihiroSuda,
cyphar,
lifubang and
thaJeztah
September 26, 2026 20:52
This package was deprecated in runc 1.5 (in favor of github.com/moby/sys/devices), with a note that it will be removed in runc 1.6. Remove it. As a result, github.com/moby/sys/devices is no longer a runc dependency. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
RecvFile, SendFile, and SendRawFd were moved to an internal package in runc 1.5, and the wrappers left in libcontainer/utils were deprecated, with a note that they will be removed in runc 1.6. Remove them. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
kolyshkin
force-pushed
the
rm-deprecated
branch
from
September 26, 2026 20:53
5dc75fb to
167781f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following APIs were deprecated in runc 1.5, with a note that they will be
removed in runc 1.6:
libcontainer/devicespackage (usegithub.com/moby/sys/devicesinstead), see #5142 and #5223;
RecvFile,SendFile, andSendRawFdfromlibcontainer/utils(moved toan internal package), see #5227.
Remove them. As a result,
github.com/moby/sys/devicesis no longer a runcdependency.