Conversation
|
We need to touch that part anyway for 1.1 I believe (and check versions / remove some entries if there were no breaking changes)? Should this change be only scoped for 1.0 for the time being and we do a pass of the non-final specs part for 1.1 before final? |
|
Discussed in call. We may need to update to 16, but only after making sure there aren't normative inconsistencies. |
jogu
left a comment
There was a problem hiding this comment.
There's still an inconsistency as the normative references section now references draft 16. We need to update the normative references to be draft 10, unless there's a later draft that has no normative changes in which change we can update both places to that later version.
|
Does @jogu 's concern only applies to the following sentence and section 2 vs 4? I don't understand the concern. is it still there if now the PR points to -16 and not -10?
|
@c2bo do you see any problems with merging this PR now and we can revisit 1.1 before publication again |
fine by me and I believe Brent opened a new issue for that |
| ##### Step 1: SD-JWT VC Processing | ||
|
|
||
| - A receiver (holder or verifier) of an SD-JWT VCLD applies the processing rules outlined in Section 4 of [@!I-D.ietf-oauth-sd-jwt-vc], including verifying signatures, validity periods, status information, etc. | ||
| - A receiver (holder or verifier) of an SD-JWT VCLD applies the processing rules outlined in Section 2 of [@!I-D.ietf-oauth-sd-jwt-vc], including verifying signatures, validity periods, status information, etc. |
There was a problem hiding this comment.
| - A receiver (holder or verifier) of an SD-JWT VCLD applies the processing rules outlined in Section 2 of [@!I-D.ietf-oauth-sd-jwt-vc], including verifying signatures, validity periods, status information, etc. | |
| - A receiver (holder or verifier) of an SD-JWT VCLD applies the processing rules outlined in Section 2.4 of [@!I-D.ietf-oauth-sd-jwt-vc], including verifying signatures, validity periods, status information, etc. |
There was a problem hiding this comment.
I agree that section 2.4 is the better reference. Section 2.4 also references the validation rules in section 2.5, so scoping it down like this makes it easier to find the rules without being too specific.
| ##### Step 1: SD-JWT VC Processing | ||
|
|
||
| - A receiver (holder or verifier) of an SD-JWT VCLD applies the processing rules outlined in Section 4 of [@!I-D.ietf-oauth-sd-jwt-vc], including verifying signatures, validity periods, status information, etc. | ||
| - A receiver (holder or verifier) of an SD-JWT VCLD applies the processing rules outlined in Section 2 of [@!I-D.ietf-oauth-sd-jwt-vc], including verifying signatures, validity periods, status information, etc. |
There was a problem hiding this comment.
| - A receiver (holder or verifier) of an SD-JWT VCLD applies the processing rules outlined in Section 2 of [@!I-D.ietf-oauth-sd-jwt-vc], including verifying signatures, validity periods, status information, etc. | |
| - A receiver (holder or verifier) of an SD-JWT VCLD applies the processing rules outlined in Section 2.4 of [@!I-D.ietf-oauth-sd-jwt-vc], including verifying signatures, validity periods, status information, etc. |
awoie
left a comment
There was a problem hiding this comment.
thanks. we should use 2.4 instead of 2.
| * SIOPv2 draft -13 [@!SIOPv2] | ||
| * Selective Disclosure for JWTs (SD-JWT) draft -22 [@!I-D.ietf-oauth-selective-disclosure-jwt] | ||
| * SD-JWT-based Verifiable Credentials (SD-JWT VC) draft -09 [@!I-D.ietf-oauth-sd-jwt-vc] | ||
| * SD-JWT-based Verifiable Credentials (SD-JWT VC) draft -16 [@!I-D.ietf-oauth-sd-jwt-vc] |
There was a problem hiding this comment.
Draft 16 contains at least one breaking change ( https://www.ietf.org/archive/id/draft-ietf-oauth-sd-jwt-vc-16.html#name-document-history ):
Change lang to locale. While lang is more accurate, locale is what has traditionally been used in OpenID Connect and later related specs.
so I don't think we can just update to -16, unless people can think of language we can add that could explain this as not really being a breaking change.
There may be other breaking changes too, I didn't review the full history.
The alternative is to figure out how to make the normative references section of the draft refer to draft 10 (or the latest version that doesn't contain breaking changes). I don't know how we get mmarkdown/xml2rfc to reference a specific IETF draft rather than the latest one - probably we would need to create a manual reference instead of relying on the automatic [@!I-D.ietf-oauth-sd-jwt-vc] syntax.
|
Below are some notable differences between draft 10 and draft 16 of the SD-JWT VC spec that could potentially present an issue.
|
I will also note that ETSI references -13. Because SD-JWT VC is probably most relevant for EUDI, and EUDI implementers will need to use -13, we should probably also use -13, or update to -16/-17 (next week) already. Between -13 and -16/-17 there shouldn't be any breaking changes. |
|
After discussion in the WG today, we don't like it, but we should point to the latest version of SD-JWT VC and move forward. |
Relevant minutes for references: https://lists.openid.net/pipermail/openid-specs-digital-credentials-protocols/Week-of-Mon-20260713/001320.html The WG can't just decide "we're going to make breaking changes in an errata". As I mentioned here #726 (comment) we really need to explain and justify why we're making a breaking change in an errata update (including making clear what behaviour we expect implementations with/without the errata update to have), and some of the explanation is likely to be guidance to implementers/ecosystems that needs to go into the specification text.
Can you expand on this point please? A registry of what? [Actually I think that question is answered by the minutes - I don't think a registry solves any of this problem - I believe it's a registry of credential format identifiers like dc+sd-jwt etc - but the registry still has to stay 'dc+sd-jwt' means "SD-JWT VC draft 18" and can't change the meaning of that value ever.) |
|
Discussion in the group today: perhaps a breaking change in this circumstance might be necessary, and allowable under the need to address errata. If we go down this route, we need to be very explicit about the changes. |
|
WG discussion (chair hat on) multiple options:
-> preferred direction seems to be option 1.
what does conformance mean? need to provide clarity:
|
|
Discussed today, @Sakurann please adjust this PR according to option 1. Make sure to mention wallet and verifier requirements. |
fixes #659 by changing typo in sd-jwt-vc version