8388339: [17u] Replacing non-ascii characters in HttpServerAdapters.java - #4574
Conversation
On some Linux distros like Ubunto and Sles, the default environment variables can lead to the non-ascii characters in this string causing any tests using this class to fail due to the unmappable characters. Signed-off-by: Adam Farley <adfarley@ibm.com>
|
👋 Welcome back afarley! A progress list of the required criteria for merging this PR into |
|
Note: this is only being merged into JDK17 because the letters with diacritics causing this issue are only present in JDK17+, and JDK25 uses UTF-8 encoding (which permits the use of these characters). |
|
❗ This change is not yet ready to be integrated. |
|
/approval 8388339 request Request to amend a string to only include ascii characters, as some Linux distros can see massive http test failures due to unmappable characters if the system is using default environment variables. |
|
@adamfarley |
openjdk
Bot
added
the
approval
|
Hi @adamfarley |
adamfarley
changed the title
openjdk
Bot
removed
the
approval
| final String responseBody; | ||
| public HttpHeadOrGetHandler() { | ||
| this("pâté de tête persillé"); | ||
| this("pate de tete persille"); |
There was a problem hiding this comment.
I would suggest replacing the non-ASCII characters by their unicode escape instead. IIRC the use of non-ASCII characters in the response body was intentional.
3 participants
On some Linux distros like Ubunto and Sles, the default environment variables can lead to the non-ascii characters in this string causing any tests using this class to fail due to the unmappable characters.
Progress
Integration blocker
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/4574/head:pull/4574$ git checkout pull/4574Update a local copy of the PR:
$ git checkout pull/4574$ git pull https://git.openjdk.org/jdk17u-dev.git pull/4574/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 4574View PR using the GUI difftool:
$ git pr show -t 4574Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/4574.diff
Using Webrev
Link to Webrev Comment