Skip to content

Handle metric direction in process_task_results#936

Merged
rcannood merged 4 commits into
mainfrom
bugfix/no-ref/handle-metric-direction
Nov 21, 2025
Merged

Handle metric direction in process_task_results#936
rcannood merged 4 commits into
mainfrom
bugfix/no-ref/handle-metric-direction

Conversation

@lazappi

@lazappi lazappi commented Nov 18, 2025

Copy link
Copy Markdown
Member

Describe your changes

Minor changes to steps in the process_task_results workflow so that metric direction is handled properly. Metrics that should be minimised should now correctly show high scaled scores for low raw scores.

Checklist before requesting a review

  • I have performed a self-review of my code

  • Check the correct box. Does this PR contain:

    • Breaking changes
    • New functionality
    • Major changes
    • Minor changes
    • Bug fixes
    • Documentation
  • Proposed changes are described in the CHANGELOG.md

  • CI Tests succeed and look good!

@lazappi lazappi requested a review from rcannood November 18, 2025 14:22
Comment thread src/reporting/generate_qc/script.R Outdated
@lazappi lazappi requested a review from rcannood November 21, 2025 12:35

@rcannood rcannood left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rcannood rcannood merged commit 0fc9241 into main Nov 21, 2025
3 checks passed
@rcannood rcannood deleted the bugfix/no-ref/handle-metric-direction branch November 21, 2025 12:54
lazappi added a commit that referenced this pull request Nov 24, 2025
…metric-direction

* origin/main:
  Handle metric direction in `process_task_results` (#936)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants