Kamil/gradle version catalog traits - #8699
Closed
KamilPatora wants to merge 13 commits into
Closed
KamilPatora wants to merge 13 commits into
KamilPatora wants to merge 13 commits into
Conversation
- Add document, library, and plugin traits for TOML catalogs - Support string and inline-table dependency/plugin entries - Coordinate shared version.ref updates - Centralize TOML table lookup and string accessors - Preserve TOML formatting during updates
…move unsupported version checks
…n to enhance value updating logic and streamline key management
…updates and improve dependency matching logic
3 tasks
Contributor
Author
|
MOved this from #8376, as I was using wrong branch from the fork |
Member
|
Thank you for this work. Your commit is carried into #8864 with authorship intact, where the settings DSL and TOML forms of a version catalog are generalized into a single |
jkschneider
added a commit
that referenced
this pull request
Sep 12, 2026
A version catalog has two homes, a `dependencyResolutionManagement { versionCatalogs { ... } }`
block in `settings.gradle(.kts)` and a `gradle/libs.versions.toml` file. `VersionCatalog.Matcher`
finds either, so `UpgradeDependencyVersion` upgrades the libraries of both through one visitor.
A shared version declaration is changed in place when every library referring to it is moving to
the same version and no plugin refers to it; otherwise the libraries that are moving detach to
versions of their own. A library whose metadata can't be downloaded is left alone and warned about
on the catalog.
Supersedes #8503 and #8699.
Co-authored-by: Alex Boyko <alex.boyko@broadcom.com>
Co-authored-by: Kamil Patora <kamil.patora@allegro.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's changed?
version.refupdates.What's your motivation?
Provide a reusable, formatting-preserving semantic model for Gradle version catalogs and enable safe dependency, plugin, and shared-version updates.
Anything in particular you'd like reviewers to focus on?
Probably whole pr
Anyone you would like to review specifically?
Have you considered any alternatives or workarounds?
We do have our open-source 'version' of openrewrite where we handle TOML values: https://github.com/allegro/allwrite
Any additional context
Added positive and negative coverage for custom catalog paths, missing version references, versionless notation, malformed coordinates, visitor composition, and TOML quote preservation.
Checklist