Add option addLast to recipe AddOrUpdateAnnotationAttribute - #8765
Open
ghusta wants to merge 1 commit into
Open
Conversation
kdelay
reviewed
Sep 5, 2026
kdelay
left a comment
There was a problem hiding this comment.
addLast=true mangles annotations whose arguments span lines. On 05644eb,
("org.junit.Test", "value", "1", null, true, false, true) turns
@Test(
other = 0
)into
@Test(
other = 0
, value = 1)The whitespace before ) is the last argument's right padding, so appending
after it renders that padding before the new comma. addLast=null on the same
input stays well formed. Moving the padding onto the appended argument yields
other = 0, value = 1 inside the parens and keeps all 81 tests in the class green.
Contributor
Author
|
@kdelay Thanks for your feedback 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's changed?
Added option
addLastto recipeAddOrUpdateAnnotationAttribute.What's your motivation?
So far, when an annotation attribute is added, it is inserted at the first position in the attributes list.
This new option will insert a new attibute at last position when true.
Checklist
./gradlew buildlocally, and committed any resulting changes torecipes.csv