Conversation
Author
|
The PR is ready for review. Local current-main Gradle testing is blocked by unavailable CodeGenome credentials; the supplemental JDK 21 results are documented above. No CI checks are currently attached to the head commit. Could a maintainer help check or enable repository CI and review the opt-in external-parent override behavior? I'm happy to address feedback. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's changed?
overrideManagedVersiontoUpgradePluginVersion, used withaddVersionIfMissing: trueto override versions inherited from an external parent.What's your motivation?
Anything in particular you'd like reviewers to focus on?
The new option deliberately leaves the existing
trustParentplaceholder unchanged. BothoverrideManagedVersionandaddVersionIfMissingmust be enabled to add an external-parent override.Validation
UpgradePluginVersionTestclass has 27 passing tests, 4 existing skips, 0 failures/errors. The affected recipe, original test class,MavenVisitor,Plugin, andResolvedPomare identical between the base commit and v8.90.4. This is supplemental validation, not a full current-main build../gradlew :rewrite-maven:test --tests 'org.openrewrite.maven.UpgradePluginVersionTest*'is blocked during configuration: the build plugin requires Rewrite 8.91.4 from CodeGenome, but no CodeGenome credentials are configured (Username must not be null!). No project dependencies or build configuration were changed to work around this.MavenRecipeMarketplaceGenerator;git diff --checkpasses.Ready for review. The normal current-main Gradle build remains blocked locally by unavailable CodeGenome credentials; awaiting repository CI validation.
Checklist
./gradlew buildlocally, and committed any resulting changes torecipes.csv