Revert "Enable context-sensitive Kotlin Templates (#8892)" - #8962
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts Enable context-sensitive Kotlin Templates #8892 in full, including the
Parser.Builderequals/hashCode it introduced.Replacing just that piece with
discriminator()(21d2351) causedNoSuchMethodErrors downstream and was itself reverted in Revert "Remove equals/hashcode from Parser.Builder implementations" #8955. This takes the whole change out in one piece rather than unwinding it further.The revert applied cleanly. Later changes to the same files (Let JavaParser skip type attribution, and report a conversion failure once #8961
typeAttributioninJavaParser, Kotlin: fix resolved-qualifier typing and syntax-error reporting #8948 and the Kotlin 2.4.20 upgrade inKotlinParser) are unaffected.