Skip to content

fix(deps): update module gopkg.in/resty.v1 to v2 #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
red-hat-konflux-kflux-prd-rh02 wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −1
Open

fix(deps): update module gopkg.in/resty.v1 to v2 #242

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ require (
go.opentelemetry.io/otel/sdk v1.43.0
go.opentelemetry.io/otel/trace v1.43.0
go.uber.org/mock v0.6.0
gopkg.in/resty.v1 v1.12.0
gopkg.in/resty.v2 v2.17.2

@coderabbitai coderabbitai Bot Jun 22, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail
rg -n --glob '!**/vendor/**' 'gopkg\.in/resty\.v1' .

Repository: openshift-hyperfleet/hyperfleet-api

Length of output: 563

go.mod pins resty.v2 but five test files still import resty.v1 — build will fail.

go.mod now contains only gopkg.in/resty.v2 v2.17.2, but the following test files still import gopkg.in/resty.v1:

  • test/integration/clusters_test.go:16
  • test/integration/metadata_test.go:26
  • test/integration/node_pools_test.go:11
  • test/integration/openapi_test.go:26
  • test/integration/wifconfigs_test.go:12

Without simultaneous migration of these imports to resty.v2, the module graph cannot satisfy v1 imports and tests will not compile or run.

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@go.mod` at line 41, The go.mod file has been updated to pin resty.v2, but
five test files still import the v1 version which causes a module graph
conflict. Update the import statements in the following test files to use
gopkg.in/resty.v2 instead of gopkg.in/resty.v1: clusters_test.go,
metadata_test.go, node_pools_test.go, openapi_test.go, and wifconfigs_test.go.
Replace each occurrence of "gopkg.in/resty.v1" with "gopkg.in/resty.v2" in the
import sections of these files, then verify the resty.v2 API usage is compatible
with the existing test code.

gorm.io/datatypes v1.2.7
gorm.io/driver/postgres v1.6.0
gorm.io/gorm v1.31.1
Expand Down