[release-4.19] OCPBUGS-90623: Allow VolumeSnapshot restore when parent PVC is deleted

[sg00dwin]

This is a manual backport of #16447 to release-4.19.

The cherry-pick had merge conflicts because the 4.19 branch still uses the older withHandlePromise class-style component pattern (extra indentation, React.useState, className props on FormGroups), while the main branch had been refactored. I resolved by applying the PR's logic changes (pvcNotFound, formReady, conditional filter, guarded isInputDisabled) while preserving the 4.19 code style.

Assisted by: Claude (Opus 4.6)

Allow VolumeSnapshot restore when the parent PVC has been deleted by using snapshot annotations to populate the restore form instead of requiring the parent PVC to exist.

Test Verification (4.19 backport)

Adapted unit tests from the main branch PR (#16447) to work with the 4.19 component structure (withHandlePromise HOC, React.useState, different import paths, no renderWithProviders util). The logic changes are identical to the 4.21 and 4.22 backports — the only differences are structural, matching the older component pattern in 4.19.

Results:

All 4 tests pass on the backport branch (with fix)
The "deleted PVC" test correctly fails on release-4.19 without the fix (skeleton loaders render instead of form fields)
3 regression tests pass on both branches, confirming no breakage
Tests:

Renders all form fields when parent PVC exists (regression)
Renders all form fields when parent PVC is deleted (OCPBUGS-59404 fix)
Shows skeleton loaders while PVC is still loading
Pre-populates restore name from snapshot name

[openshift-ci-robot]

@sg00dwin: This pull request references Jira Issue OCPBUGS-59404, which is invalid:

• expected the bug to target either version "4.19." or "openshift-4.19.", but it targets "5.0.0" instead
• expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is Verified instead
• expected Jira Issue OCPBUGS-59404 to depend on a bug targeting a version in 4.20.0, 4.20.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is a manual backport of #16447 to release-4.19.

/cherry-pick-from-pr:16447

Allow VolumeSnapshot restore when the parent PVC has been deleted by using snapshot annotations to populate the restore form instead of requiring the parent PVC to exist.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: b3c69432-d8e9-4f99-aa44-b88b20cb6f8c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sg00dwin
Once this PR has been reviewed and has the lgtm label, please assign spadgett for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• frontend/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@sg00dwin: This pull request references Jira Issue OCPBUGS-90623, which is invalid:

• expected the bug to target either version "4.19." or "openshift-4.19.", but it targets "4.20.0" instead
• expected Jira Issue OCPBUGS-90623 to depend on a bug targeting a version in 4.20.0, 4.20.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is a manual backport of #16447 to release-4.19.

The cherry-pick had merge conflicts because the 4.19 branch still uses the older withHandlePromise class-style component pattern (extra indentation, React.useState, className props on FormGroups), while the main branch had been refactored. I resolved by applying the PR's logic changes (pvcNotFound, formReady, conditional filter, guarded isInputDisabled) while preserving the 4.19 code style.

Assisted by: Claude (Opus 4.6)

Allow VolumeSnapshot restore when the parent PVC has been deleted by using snapshot annotations to populate the restore form instead of requiring the parent PVC to exist.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[sg00dwin]

/jira refresh

[openshift-ci-robot]

@sg00dwin: This pull request references Jira Issue OCPBUGS-90623, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.19.z) matches configured target version for branch (4.19.z)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
• release note text is set and does not match the template
• dependent bug Jira Issue OCPBUGS-89235 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
• dependent Jira Issue OCPBUGS-89235 targets the "4.20.0" version, which is one of the valid target versions: 4.20.0, 4.20.z
• bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (yapei@redhat.com), skipping review request.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[sg00dwin]

/test e2e-gcp-console

[sg00dwin]

/test e2e-gcp-console

[openshift-ci-robot]

@sg00dwin: This pull request references Jira Issue OCPBUGS-90623, which is valid.

7 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.19.z) matches configured target version for branch (4.19.z)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
• release note text is set and does not match the template
• dependent bug Jira Issue OCPBUGS-89235 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
• dependent Jira Issue OCPBUGS-89235 targets the "4.20.0" version, which is one of the valid target versions: 4.20.0, 4.20.z
• bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (yapei@redhat.com), skipping review request.

Details

In response to this:

This is a manual backport of #16447 to release-4.19.

The cherry-pick had merge conflicts because the 4.19 branch still uses the older withHandlePromise class-style component pattern (extra indentation, React.useState, className props on FormGroups), while the main branch had been refactored. I resolved by applying the PR's logic changes (pvcNotFound, formReady, conditional filter, guarded isInputDisabled) while preserving the 4.19 code style.

Assisted by: Claude (Opus 4.6)

Allow VolumeSnapshot restore when the parent PVC has been deleted by using snapshot annotations to populate the restore form instead of requiring the parent PVC to exist.

Test Verification (4.19 backport)

Adapted unit tests from the main branch PR (#16447) to work with the 4.19 component structure (withHandlePromise HOC, React.useState, different import paths, no renderWithProviders util). The logic changes are identical to the 4.21 and 4.22 backports — the only differences are structural, matching the older component pattern in 4.19.

Results:

All 4 tests pass on the backport branch (with fix)
The "deleted PVC" test correctly fails on release-4.19 without the fix (skeleton loaders render instead of form fields)
3 regression tests pass on both branches, confirming no breakage
Tests:

Renders all form fields when parent PVC exists (regression)
Renders all form fields when parent PVC is deleted (OCPBUGS-59404 fix)
Shows skeleton loaders while PVC is still loading
Pre-populates restore name from snapshot name

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[sg00dwin]

/verified by @sg00dwin and claude

[openshift-ci-robot]

@sg00dwin: This PR has been marked as verified by @sg00dwin and claude.

Details

In response to this:

/verified by @sg00dwin and claude

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

@sg00dwin: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.