Skip to content

OCPBUGS-120684: Update stale comment - #17141

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
logonoff:OCPBUGS-120684-embargoed
Sep 4, 2026
Merged

OCPBUGS-120684: Update stale comment#17141
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
logonoff:OCPBUGS-120684-embargoed

Conversation

@logonoff

@logonoff logonoff commented Sep 3, 2026

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • Tests
    • Updated the end-to-end test skip annotation to reference the correct TechPreview test script.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Sep 3, 2026
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@logonoff: This pull request references Jira Issue OCPBUGS-120684, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (5.1.0) matches configured target version for branch (5.1.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@logonoff

logonoff commented Sep 3, 2026

Copy link
Copy Markdown
Member Author

/cherry-pick release-5.0
/verified bypass

@openshift-ci
openshift-ci Bot requested review from fsgreco and rhamilto September 3, 2026 18:38
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 3, 2026
@openshift-cherrypick-robot

Copy link
Copy Markdown

@logonoff: once the present PR merges, I will cherry-pick it on top of release-5.0 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-5.0
/verified bypass

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@coderabbitai

coderabbitai Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 261341a9-a085-4e6e-8dc7-0f309eccfc48

📥 Commits

Reviewing files that changed from the base of the PR and between bf976c1 and 6f2070d.

📒 Files selected for processing (1)
  • frontend/e2e/tests/dev-console/catalog.spec.ts

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.


Walkthrough

The TechPreview skip comment now references test-prow-e2e-techpreview.sh instead of the previous script name.

Changes

TechPreview test metadata

Layer / File(s) Summary
Update TechPreview script reference
frontend/e2e/tests/dev-console/catalog.spec.ts
The skip comment identifies test-prow-e2e-techpreview.sh as the TechPreview test execution script.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 6f207

This updates documentation for the TechPreview test script reference without changing product or test behavior. No merge-readiness risk remains.

🚥 Pre-merge checks | ✅ 14 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning No pull request description was provided. The required root cause, solution, testing, browser conformance, and reviewer sections are missing. Add a pull request description that follows the repository template. Include the analysis or root cause, solution description, screenshots status, test setup, test cases, browser conformance, additional information, and reviewers or assigne…
✅ Passed checks (14 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the Jira issue and the main change: updating a stale comment.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PASS. The pull request changes one comment only in frontend/e2e/tests/dev-console/catalog.spec.ts. It replaces one script name with another. The patch does not change any test title or add dynamic t…
Test Structure And Quality ✅ Passed PASS: The pull request changes one comment in frontend/e2e/tests/dev-console/catalog.spec.ts. It does not change test behavior, setup, cleanup, waits, or assertions. The file uses Playwright (`test.…
Microshift Test Compatibility ✅ Passed PASS: The pull request changes only one comment in frontend/e2e/tests/dev-console/catalog.spec.ts. The diff adds no Ginkgo test or test behavior. The file uses Playwright test APIs, and the existi…
Single Node Openshift (Sno) Test Compatibility ✅ Passed PASS — The pull request changes only one comment in frontend/e2e/tests/dev-console/catalog.spec.ts. The file uses Playwright (test and expect), and the diff adds no Ginkgo e2e tests or test beha…
Topology-Aware Scheduling Compatibility ✅ Passed PASS: The pull request changes only one comment in frontend/e2e/tests/dev-console/catalog.spec.ts. The diff updates the TechPreview script name from test-prow-playwright-e2e-techpreview.sh to `tes…
Ote Binary Stdout Contract ✅ Passed PASS: The pull request changes only one comment in frontend/e2e/tests/dev-console/catalog.spec.ts, correcting a script name. It adds no executable code and introduces no stdout write in main(), su…
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PASS: The commit changes only one comment in frontend/e2e/tests/dev-console/catalog.spec.ts (1 insertion, 1 deletion). It adds no Ginkgo e2e test and introduces no IPv4 assumption or external conn…
No-Weak-Crypto ✅ Passed PASS. The pull request changes one comment only in frontend/e2e/tests/dev-console/catalog.spec.ts. The parent-to-HEAD diff contains no MD5, SHA1, DES, 3DES, RC4, Blowfish, ECB, custom crypto, or sec…
Container-Privileges ✅ Passed PASS: The commit changes one comment in frontend/e2e/tests/dev-console/catalog.spec.ts. It only renames the referenced TechPreview script from test-prow-playwright-e2e-techpreview.sh to `test-prow…
No-Sensitive-Data-In-Logs ✅ Passed The pull request changes one comment only: it renames the referenced script from test-prow-playwright-e2e-techpreview.sh to test-prow-e2e-techpreview.sh. The diff adds no logging, credentials, tok…
Full details: Description check

Resolution

Add a pull request description that follows the repository template. Include the analysis or root cause, solution description, screenshots status, test setup, test cases, browser conformance, additional information, and reviewers or assignees.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files.

Full details: Stable And Deterministic Test Names

Explanation

PASS. The pull request changes one comment only in frontend/e2e/tests/dev-console/catalog.spec.ts. It replaces one script name with another. The patch does not change any test title or add dynamic test-name content. The file uses Playwright test() and test.describe() declarations, not Ginkgo declarations.

Full details: Test Structure And Quality

Explanation

PASS: The pull request changes one comment in frontend/e2e/tests/dev-console/catalog.spec.ts. It does not change test behavior, setup, cleanup, waits, or assertions. The file uses Playwright (test.describe, test.beforeEach, and test), not Ginkgo. Therefore, the stated Ginkgo test-quality failure conditions are not introduced.

Full details: Microshift Test Compatibility

Explanation

PASS: The pull request changes only one comment in frontend/e2e/tests/dev-console/catalog.spec.ts. The diff adds no Ginkgo test or test behavior. The file uses Playwright test APIs, and the existing TechPreview skip remains unchanged. Therefore, the custom MicroShift test-compatibility failure conditions do not apply.

Full details: Single Node Openshift (Sno) Test Compatibility

Explanation

PASS — The pull request changes only one comment in frontend/e2e/tests/dev-console/catalog.spec.ts. The file uses Playwright (test and expect), and the diff adds no Ginkgo e2e tests or test behavior. Therefore, the SNO compatibility check is not applicable.

Full details: Topology-Aware Scheduling Compatibility

Explanation

PASS: The pull request changes only one comment in frontend/e2e/tests/dev-console/catalog.spec.ts. The diff updates the TechPreview script name from test-prow-playwright-e2e-techpreview.sh to test-prow-e2e-techpreview.sh. It adds or modifies no deployment manifest, operator code, controller, replica setting, affinity, topology spread constraint, node selector, toleration, or PDB. The topology-aware scheduling check is therefore not applicable.

Full details: Ote Binary Stdout Contract

Explanation

PASS: The pull request changes only one comment in frontend/e2e/tests/dev-console/catalog.spec.ts, correcting a script name. It adds no executable code and introduces no stdout write in main(), suite setup, or any other process-level code.

Full details: Ipv6 And Disconnected Network Test Compatibility

Explanation

PASS: The commit changes only one comment in frontend/e2e/tests/dev-console/catalog.spec.ts (1 insertion, 1 deletion). It adds no Ginkgo e2e test and introduces no IPv4 assumption or external connectivity requirement. The file uses Playwright test.describe/test, and the added line is comment text only.

Full details: No-Weak-Crypto

Explanation

PASS. The pull request changes one comment only in frontend/e2e/tests/dev-console/catalog.spec.ts. The parent-to-HEAD diff contains no MD5, SHA1, DES, 3DES, RC4, Blowfish, ECB, custom crypto, or secret-comparison code. No weak-crypto usage is introduced.

Full details: Container-Privileges

Explanation

PASS: The commit changes one comment in frontend/e2e/tests/dev-console/catalog.spec.ts. It only renames the referenced TechPreview script from test-prow-playwright-e2e-techpreview.sh to test-prow-e2e-techpreview.sh. It does not change a container or Kubernetes manifest and does not introduce privileged, host namespaces, SYS_ADMIN, root execution, or allowPrivilegeEscalation: true.

Full details: No-Sensitive-Data-In-Logs

Explanation

The pull request changes one comment only: it renames the referenced script from test-prow-playwright-e2e-techpreview.sh to test-prow-e2e-techpreview.sh. The diff adds no logging, credentials, tokens, personal data, hostnames, or customer data.

  • Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Sep 3, 2026
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@logonoff: The verified label has been added.

Details

In response to this:

/cherry-pick release-5.0
/verified bypass

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@logonoff: This pull request references Jira Issue OCPBUGS-120684, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (5.1.0) matches configured target version for branch (5.1.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
Details

In response to this:

Summary by CodeRabbit

  • Tests
  • Updated the end-to-end test skip annotation to reference the correct TechPreview test script.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@logonoff

logonoff commented Sep 3, 2026

Copy link
Copy Markdown
Member Author

/pipeline required

@rhamilto

rhamilto commented Sep 3, 2026

Copy link
Copy Markdown
Member

/approve
/lgtm

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-cypress
/test e2e-gcp-console
/test e2e-gcp-console-techpreview

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 3, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-cypress
/test e2e-gcp-console
/test e2e-gcp-console-techpreview

@openshift-ci

openshift-ci Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: logonoff, rhamilto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

/retest-required

Remaining retests: 0 against base HEAD bf976c1 and 2 for PR HEAD 6f2070d in total

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

/retest-required

Remaining retests: 0 against base HEAD b09672c and 1 for PR HEAD 6f2070d in total

@rhamilto

rhamilto commented Sep 3, 2026

Copy link
Copy Markdown
Member

/retest

@logonoff

logonoff commented Sep 4, 2026

Copy link
Copy Markdown
Member Author

sigh

/override ci/prow/e2e-gcp-console

@openshift-ci

openshift-ci Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

@logonoff: Overrode contexts on behalf of logonoff: ci/prow/e2e-gcp-console

Details

In response to this:

sign

/override ci/prow/e2e-gcp-console

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci

openshift-ci Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

@logonoff: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot
openshift-merge-bot Bot merged commit e503d33 into openshift:main Sep 4, 2026
10 checks passed
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@logonoff: Jira Issue Verification Checks: Jira Issue OCPBUGS-120684
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-120684 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

Summary by CodeRabbit

  • Tests
  • Updated the end-to-end test skip annotation to reference the correct TechPreview test script.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-cherrypick-robot

Copy link
Copy Markdown

@logonoff: new pull request created: #17143

Details

In response to this:

/cherry-pick release-5.0
/verified bypass

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-robot

Copy link
Copy Markdown
Contributor

Fix included in release 5.1.0-0.nightly-2026-09-04-115839

@logonoff
logonoff deleted the OCPBUGS-120684-embargoed branch September 4, 2026 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants