[release-5.0] OCPBUGS-120722: Helm backend test flake: parallel packages race on global pkill chartmuseum - #17144
Conversation
…cleanup Both pkg/helm/actions and pkg/helm/chartproxy start chartmuseum processes independently. The stop scripts used `pkill -15 chartmuseum` which kills ALL chartmuseum processes system-wide. When `go test ./...` runs these packages in parallel, one package's cleanup can kill the other's chartmuseum mid-startup, causing a panic. Replace global pkill with PID-file based kills (matching the pattern already used by zot stop scripts): - actions: write PID files for all three chartmuseum variants (TLS, no-TLS, basic-auth) and kill by PID in stop script - chartproxy: convert start script to exec pattern with PID file, kill by PID in stop script - cleanup scripts: remove PID files alongside other artifacts - diagnostics: check all PID files on timeout, not just TLS Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Validate PID values before passing to kill to prevent unintended arguments from malformed PID files. Check PID file writes succeed before exec to ensure stop scripts can terminate the process. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
OCPBUGS-115318 kill -TERM 0 sends the signal to the entire process group rather than a single process. Tighten the PID regex from ^[0-9]+$ to ^[1-9][0-9]*$ so that a zero value is treated as invalid. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
OCPBUGS-115318 Before sending SIGTERM, check that the PID from the PID file still belongs to a chartmuseum process using ps. This prevents stale PID files from accidentally terminating unrelated processes. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Pipeline controller notification For optional jobs, comment This repository is configured in: LGTM mode |
|
@platex-rehor-bot: This pull request references Jira Issue OCPBUGS-120722, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: platex-rehor-bot The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @platex-rehor-bot. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Tip We noticed you've done this a few times! Consider joining the org to skip this step and gain Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/jira refresh |
|
@platex-rehor-bot: This pull request references Jira Issue OCPBUGS-120722, which is valid. 7 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/ok-to-test |
|
/retest |
|
@platex-rehor-bot: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Bug
OCPBUGS-120722
Backport of OCPBUGS-115318 to release-5.0.
Original fix: #17128
Changes
Cherry-picked from main (4 commits).
/jira cherrypick OCPBUGS-120722