Skip to content

[release-5.0] OCPBUGS-120722: Helm backend test flake: parallel packages race on global pkill chartmuseum - #17144

Open
platex-rehor-bot wants to merge 4 commits into
openshift:release-5.0from
platex-rehor-bot:bot/OCPBUGS-120722
Open

[release-5.0] OCPBUGS-120722: Helm backend test flake: parallel packages race on global pkill chartmuseum#17144
platex-rehor-bot wants to merge 4 commits into
openshift:release-5.0from
platex-rehor-bot:bot/OCPBUGS-120722

Conversation

@platex-rehor-bot

Copy link
Copy Markdown
Contributor

Bug

OCPBUGS-120722

Backport of OCPBUGS-115318 to release-5.0.
Original fix: #17128

Changes

Cherry-picked from main (4 commits).

/jira cherrypick OCPBUGS-120722

platex-rehor-bot and others added 4 commits September 4, 2026 07:07
…cleanup

Both pkg/helm/actions and pkg/helm/chartproxy start chartmuseum
processes independently. The stop scripts used `pkill -15 chartmuseum`
which kills ALL chartmuseum processes system-wide. When `go test ./...`
runs these packages in parallel, one package's cleanup can kill the
other's chartmuseum mid-startup, causing a panic.

Replace global pkill with PID-file based kills (matching the pattern
already used by zot stop scripts):

- actions: write PID files for all three chartmuseum variants
  (TLS, no-TLS, basic-auth) and kill by PID in stop script
- chartproxy: convert start script to exec pattern with PID file,
  kill by PID in stop script
- cleanup scripts: remove PID files alongside other artifacts
- diagnostics: check all PID files on timeout, not just TLS

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Validate PID values before passing to kill to prevent unintended
arguments from malformed PID files. Check PID file writes succeed
before exec to ensure stop scripts can terminate the process.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
OCPBUGS-115318
kill -TERM 0 sends the signal to the entire process group rather than
a single process.  Tighten the PID regex from ^[0-9]+$ to ^[1-9][0-9]*$
so that a zero value is treated as invalid.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
OCPBUGS-115318
Before sending SIGTERM, check that the PID from the PID file still
belongs to a chartmuseum process using ps. This prevents stale PID
files from accidentally terminating unrelated processes.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Sep 4, 2026
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@platex-rehor-bot: This pull request references Jira Issue OCPBUGS-120722, which is invalid:

  • expected the bug to target the "5.0.0" version, but no target version was set
  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Bug

OCPBUGS-120722

Backport of OCPBUGS-115318 to release-5.0.
Original fix: #17128

Changes

Cherry-picked from main (4 commits).

/jira cherrypick OCPBUGS-120722

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai

coderabbitai Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Team

Run ID: d59d2892-dace-4d9a-baf8-2e35c51c6193

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@openshift-ci
openshift-ci Bot requested review from baijum and sowmya-sl September 4, 2026 07:08
@openshift-ci openshift-ci Bot added the component/backend Related to backend label Sep 4, 2026
@openshift-ci

openshift-ci Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: platex-rehor-bot
Once this PR has been reviewed and has the lgtm label, please assign martinszuc for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci

openshift-ci Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Hi @platex-rehor-bot. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci Bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 4, 2026
@platex-rehor-bot

Copy link
Copy Markdown
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Sep 4, 2026
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@platex-rehor-bot: This pull request references Jira Issue OCPBUGS-120722, which is valid.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (5.0.0) matches configured target version for branch (5.0.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-115318 is in the state MODIFIED, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-115318 targets the "5.1" version, which is one of the valid target versions: 5.1.0
  • bug has dependents
Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Sep 4, 2026
@jhadvig

jhadvig commented Sep 4, 2026

Copy link
Copy Markdown
Member

/ok-to-test

@openshift-ci openshift-ci Bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 4, 2026
@platex-rehor-bot

Copy link
Copy Markdown
Contributor Author

/retest

@openshift-ci

openshift-ci Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

@platex-rehor-bot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/frontend f1765e6 link true /test frontend
ci/prow/analyze f1765e6 link true /test analyze

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component/backend Related to backend jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants