STOR-3090: Enable pod-delete-after-umount CSI suite for driver OCP manifests by radeore · Pull Request #596 · openshift/csi-operator

radeore · 2026-08-11T18:51:20Z

Summary

Enable the OpenShift CSI Pod delete after umount test suite for AWS EBS, AWS EFS, Azure Disk, Azure File, and GCP PD by adding podDeleteAfterUmount: true to each driver's ocp-manifest.yaml.
Split OpenShift-specific CSI test manifests into standard and long variants for AWS EBS, AWS EFS, Azure Disk, Azure File, and GCP PD.
ocp-manifest.yaml — standard jobs: enables podDeleteAfterUmount and disables LUN stress (PodsTotal: 0)
ocp-manifest-long.yaml — long certification jobs: retains existing LUN stress settings (driver-specific PodsTotal / Timeout)
This aligns with openshift/origin#31488, which gates the Pod delete after umount suite via Capabilities.podDeleteAfterUmount in the OpenShift CSI manifest (TEST_OCP_CSI_DRIVER_FILES).

Upstream manifest.yaml files are unchanged.

Adds capability podDeleteAfterUmount: true to OpenShift CSI driver ocp-manifests:

test/e2e/aws-ebs/ocp-manifest.yaml
test/e2e/aws-efs/ocp-manifest.yaml
test/e2e/azure-disk/ocp-manifest.yaml
test/e2e/azure-file/ocp-manifest.yaml
test/e2e/gcp-pd/ocp-manifest.yaml

openshift-merge-bot · 2026-08-11T18:51:22Z

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

openshift-ci-robot · 2026-08-11T18:51:24Z

@radeore: This pull request references STOR-3090 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Summary

Adds PodDeleteAfterUmountTest: true to OpenShift CSI driver config manifests for:
test/e2e/aws-ebs/ocp-manifest.yaml
test/e2e/aws-efs/ocp-manifest.yaml
test/e2e/azure-disk/ocp-manifest.yaml
test/e2e/azure-file/ocp-manifest.yaml
This enables the 'OpenShift CSI extended - Pod delete after umount suite' for these drivers, aligning csi-operator test manifests with the new origin test-gating flag introduced in openshift/origin#31488.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

coderabbitai · 2026-08-11T18:52:20Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Team

Run ID: 7d2ab270-4181-4300-ab75-d4ce13c5193c

📥 Commits

Reviewing files that changed from the base of the PR and between 5b224d8 and 265fd0c.

📒 Files selected for processing (10)

test/e2e/aws-ebs/ocp-manifest-long.yaml
test/e2e/aws-ebs/ocp-manifest.yaml
test/e2e/aws-efs/ocp-manifest-long.yaml
test/e2e/aws-efs/ocp-manifest.yaml
test/e2e/azure-disk/ocp-manifest-long.yaml
test/e2e/azure-disk/ocp-manifest.yaml
test/e2e/azure-file/ocp-manifest-long.yaml
test/e2e/azure-file/ocp-manifest.yaml
test/e2e/gcp-pd/ocp-manifest-long.yaml
test/e2e/gcp-pd/ocp-manifest.yaml

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

📝 Walkthrough

Walkthrough

The five standard CSI driver manifests now enable Capabilities.podDeleteAfterUmount: true and disable their LUN stress tests with PodsTotal: 0. New long manifests configure AWS EBS, AWS EFS, Azure Disk, Azure File, and GCP PD stress tests with driver-specific pod counts and timeouts.

Merge Risk: ⚪ Minimal · up to 265fd

OpenShift CSI E2E manifests now use pod deletion after unmount and separate standard from long LUN stress execution. The supplied configuration review identifies no remaining merge-readiness risk.

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly summarizes the main change: enabling the pod-delete-after-umount CSI suite in OpenShift driver manifests.
Description check	✅ Passed	The description accurately covers the capability changes, manifest split, LUN stress configuration, and unchanged upstream manifests.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	PASS: The pull request changes only ten static YAML manifests. The diff adds driver names, the boolean `podDeleteAfterUmount` capability, and numeric timeout/pod-count configuration. It adds no `It()`…
Test Structure And Quality	✅ Passed	PASS — The pull request changes only ten YAML manifests; it does not add or modify any Ginkgo `It` blocks, setup/cleanup hooks, waits, or assertions. Standard manifests set `PodsTotal: 0`, so the disa…
Microshift Test Compatibility	✅ Passed	PASS: The pull request changes only 10 YAML manifests. The diff adds no Ginkgo test declarations, test bodies, OpenShift API references, namespaces, or unsupported feature assumptions. Therefore, the …
Single Node Openshift (Sno) Test Compatibility	✅ Passed	PASS — The pull request changes only ten YAML manifests. The diff adds no Ginkgo test declarations or test source files, and the changed files contain no `It()`, `Describe()`, `Context()`, or `When()`…
Topology-Aware Scheduling Compatibility	✅ Passed	PASS: The commit changes only ten CSI test configuration YAML files. The added and modified fields are `Capabilities.podDeleteAfterUmount`, `LUNStressTest.PodsTotal`, and `Timeout`. The manifests cont…
Ote Binary Stdout Contract	✅ Passed	PASS: The pull request changes only 10 YAML manifest files. It adds `Capabilities.podDeleteAfterUmount` and changes `LUNStressTest` settings. It does not change Go code, process entry points, suite se…
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	PASS: The pull request changes only ten YAML manifests. It adds no Ginkgo declarations or test code. The added values contain driver names, capability flags, pod counts, and timeouts only. No hardcode…
No-Weak-Crypto	✅ Passed	The pull request changes only ten OpenShift YAML manifests. The added and modified lines contain driver names, `podDeleteAfterUmount`, `PodsTotal`, and timeout values. The exact diff contains no MD5, …
Container-Privileges	✅ Passed	The pull request changes only OpenShift CSI test configuration files. Each changed file contains `Driver`, `Capabilities.podDeleteAfterUmount`, and `LUNStressTest` settings. No changed line contains `…
No-Sensitive-Data-In-Logs	✅ Passed	PASS: The pull request changes only ten YAML manifests. The added values are CSI driver identifiers, the boolean `podDeleteAfterUmount`, pod counts, timeouts, and test comments. No logging statements,…

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (10 skipped: 10 unsupported.)

Full details: Stable And Deterministic Test Names

Explanation

PASS: The pull request changes only ten static YAML manifests. The diff adds driver names, the boolean podDeleteAfterUmount capability, and numeric timeout/pod-count configuration. It adds no It(), Describe(), Context(), or When() title and no dynamic value in a test title. The repository search also found no Ginkgo title construct in the changed directories.

Full details: Test Structure And Quality

Explanation

PASS — The pull request changes only ten YAML manifests; it does not add or modify any Ginkgo It blocks, setup/cleanup hooks, waits, or assertions. Standard manifests set PodsTotal: 0, so the disabled LUN stress test has no cluster operation requiring a timeout. The new long manifests retain explicit Timeout values. Therefore none of the stated Ginkgo test quality failure conditions is introduced.

Full details: Microshift Test Compatibility

Explanation

PASS: The pull request changes only 10 YAML manifests. The diff adds no Ginkgo test declarations, test bodies, OpenShift API references, namespaces, or unsupported feature assumptions. Therefore, the MicroShift Test Compatibility check is not applicable.

Full details: Single Node Openshift (Sno) Test Compatibility

Explanation

PASS — The pull request changes only ten YAML manifests. The diff adds no Ginkgo test declarations or test source files, and the changed files contain no It(), Describe(), Context(), or When() blocks. The SNO check therefore does not apply.

Full details: Topology-Aware Scheduling Compatibility

Explanation

PASS: The commit changes only ten CSI test configuration YAML files. The added and modified fields are Capabilities.podDeleteAfterUmount, LUNStressTest.PodsTotal, and Timeout. The manifests contain no node selectors, node affinity, anti-affinity, topology spread constraints, tolerations, replica settings, PDBs, or rolling-update settings. The long manifests only restore existing stress-test counts and timeouts. Therefore, the pull request introduces no scheduling constraint covered by this check.

Full details: Ote Binary Stdout Contract

Explanation

PASS: The pull request changes only 10 YAML manifest files. It adds Capabilities.podDeleteAfterUmount and changes LUNStressTest settings. It does not change Go code, process entry points, suite setup, logging, or stdout writes. The OTE Binary Stdout Contract is therefore not violated.

Full details: Ipv6 And Disconnected Network Test Compatibility

Explanation

PASS: The pull request changes only ten YAML manifests. It adds no Ginkgo declarations or test code. The added values contain driver names, capability flags, pod counts, and timeouts only. No hardcoded IPv4 addresses, URLs, public hostnames, or download commands appear in the changed files. The compatibility check is therefore not applicable.

Full details: No-Weak-Crypto

Explanation

The pull request changes only ten OpenShift YAML manifests. The added and modified lines contain driver names, podDeleteAfterUmount, PodsTotal, and timeout values. The exact diff contains no MD5, SHA1, DES, 3DES, RC4, Blowfish, ECB, cryptographic code, or secret/token comparisons. The check has no applicable weak-crypto finding.

Full details: Container-Privileges

Explanation

The pull request changes only OpenShift CSI test configuration files. Each changed file contains Driver, Capabilities.podDeleteAfterUmount, and LUNStressTest settings. No changed line contains privileged: true, hostPID, hostNetwork, hostIPC, SYS_ADMIN, allowPrivilegeEscalation, or a root security context. The Capabilities key is a CSI test capability, not a container security context.

Full details: No-Sensitive-Data-In-Logs

Explanation

PASS: The pull request changes only ten YAML manifests. The added values are CSI driver identifiers, the boolean podDeleteAfterUmount, pod counts, timeouts, and test comments. No logging statements, credentials, tokens, PII, internal hostnames, or customer data were introduced.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

_{Comment @coderabbitai help to get the list of available commands.}

radeore · 2026-08-13T13:44:17Z

/retest-required

radeore · 2026-08-13T21:51:30Z

/retest-required

openshift-ci-robot · 2026-08-14T15:07:15Z

@radeore: This pull request references STOR-3090 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "5.1.0" version, but no target version was set.

Details

In response to this:

Summary

Enable the OpenShift CSI Pod delete after umount test suite for AWS EBS, AWS EFS, Azure Disk, Azure File, and GCP PD by adding podDeleteAfterUmount: true to each driver's ocp-manifest.yaml.

Split OpenShift-specific CSI test manifests into standard and long variants for AWS EBS, AWS EFS, Azure Disk, Azure File, and GCP PD.

ocp-manifest.yaml — standard jobs: enables podDeleteAfterUmount and disables LUN stress (PodsTotal: 0)

ocp-manifest-long.yaml — long certification jobs: retains existing LUN stress settings (driver-specific PodsTotal / Timeout)

This aligns with openshift/origin#31488, which gates the Pod delete after umount suite via Capabilities.podDeleteAfterUmount in the OpenShift CSI manifest (TEST_OCP_CSI_DRIVER_FILES).

Upstream manifest.yaml files are unchanged.

Adds capability podDeleteAfterUmount: true to OpenShift CSI driver ocp-manifests:
test/e2e/aws-ebs/ocp-manifest.yaml
test/e2e/aws-efs/ocp-manifest.yaml
test/e2e/azure-disk/ocp-manifest.yaml
test/e2e/azure-file/ocp-manifest.yaml
test/e2e/gcp-pd/ocp-manifest.yaml

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2026-08-27T09:13:45Z

@jsafrane: This PR was included in a payload test run from openshift/origin#31488
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-main-nightly-5.1-e2e-aws-csi

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/973e69c0-a1f7-11f1-805a-811a332893ff-0

openshift-ci · 2026-08-27T13:40:22Z

@jsafrane: This PR was included in a payload test run from openshift/origin#31488
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-main-nightly-5.1-e2e-aws-csi

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/d304b0c0-a21c-11f1-8167-dd6435b48ba4-0

openshift-ci · 2026-08-31T15:31:53Z

@jsafrane: This PR was included in a payload test run from openshift/origin#31488
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-main-nightly-5.1-e2e-aws-csi

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/fc29a370-a550-11f1-80da-92cfff8f0c5a-0

openshift-ci · 2026-09-01T08:09:15Z

@jsafrane: This PR was included in a payload test run from openshift/origin#31488
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-main-nightly-5.1-e2e-aws-csi

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/58448630-a5dc-11f1-82dc-78c295b79a75-0

jsafrane · 2026-09-01T14:06:16Z

/lgtm
/approve

openshift-merge-bot · 2026-09-01T14:06:47Z

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-upgrade
/test e2e-azure
/test e2e-azure-csi
/test e2e-azure-file-csi
/test e2e-azure-file-nfs-csi
/test e2e-azure-ovn-upgrade
/test e2e-gcp
/test e2e-gcp-csi
/test e2e-gcp-ovn-upgrade

openshift-ci · 2026-09-01T14:06:48Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane, radeore

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [jsafrane]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

jsafrane · 2026-09-01T15:50:54Z

/retest-required

openshift-ci · 2026-09-02T12:15:58Z

@jsafrane: This PR was included in a payload test run from openshift/origin#31488
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-main-nightly-5.1-e2e-aws-csi

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/0a8eb270-a6c8-11f1-849f-a15404698a96-0

jsafrane · 2026-09-02T13:12:49Z

/override ci/prow/e2e-gcp
https://redhat.atlassian.net/browse/OCPBUGS-115138

openshift-ci · 2026-09-02T13:14:35Z

@jsafrane: Overrode contexts on behalf of jsafrane: ci/prow/e2e-gcp

Details

In response to this:

/override ci/prow/e2e-gcp
https://redhat.atlassian.net/browse/OCPBUGS-115138

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

radeore · 2026-09-02T20:42:58Z

/jira refresh

openshift-ci-robot · 2026-09-02T20:43:02Z

@radeore: This pull request references STOR-3090 which is a valid jira issue.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

jsafrane · 2026-09-03T12:11:11Z

/lgtm cancel

…nifests

openshift-ci · 2026-09-03T17:59:40Z

@radeore: This PR was included in a payload test run from openshift/origin#31488
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-main-nightly-5.1-e2e-aws-csi

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/34655960-a7c1-11f1-97c7-0aaf55e75feb-0

radeore · 2026-09-03T20:50:38Z

/retest-required

radeore · 2026-09-03T21:25:34Z

/retest-required

openshift-ci · 2026-09-03T22:20:00Z

@radeore: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-gcp	`e668feb`	link	true	`/test e2e-gcp`
ci/prow/hypershift-aws-e2e-external	`265fd0c`	link	true	`/test hypershift-aws-e2e-external`
ci/prow/okd-scos-images	`265fd0c`	link	true	`/test okd-scos-images`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 11, 2026

openshift-ci Bot requested review from dobsonj and stephenfin August 11, 2026 18:51

jsafrane mentioned this pull request Aug 12, 2026

STOR-3090: Add CSI storage test for pod delete after host umount of mounted volume openshift/origin#31488

Open

3 tasks

radeore force-pushed the umount-test branch from 504e9c1 to 5b224d8 Compare August 13, 2026 18:57

radeore force-pushed the umount-test branch from 5b224d8 to e668feb Compare August 14, 2026 15:03

radeore mentioned this pull request Aug 14, 2026

STOR-3090: Select ocp-manifest vs ocp-manifest-long for CSI OCP test manifests openshift/release#83463

Merged

openshift-ci Bot assigned jsafrane Sep 1, 2026

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 1, 2026

openshift-ci Bot assigned radeore Sep 1, 2026

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 1, 2026

jsafrane mentioned this pull request Sep 1, 2026

Revert "STOR-3090: Select ocp-manifest vs ocp-manifest-long for CSI O… openshift/release#84395

Merged

radeore mentioned this pull request Sep 1, 2026

STOR-3090: Select ocp-manifest vs ocp-manifest-long with fallback for older releases openshift/release#84414

Merged

jsafrane reviewed Sep 3, 2026

View reviewed changes

Comment thread test/e2e/aws-ebs/ocp-manifest-long.yaml

Comment thread test/e2e/aws-efs/ocp-manifest-long.yaml

Comment thread test/e2e/azure-disk/ocp-manifest-long.yaml

Comment thread test/e2e/azure-file/ocp-manifest-long.yaml

Comment thread test/e2e/gcp-pd/ocp-manifest-long.yaml

openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 3, 2026

STOR-3090: Enable pod-delete-after-umount CSI suite for driver OCP ma…

265fd0c

…nifests

radeore force-pushed the umount-test branch from e668feb to 265fd0c Compare September 3, 2026 17:18

Uh oh!

Conversation

radeore commented Aug 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Uh oh!

openshift-merge-bot Bot commented Aug 11, 2026

Uh oh!

openshift-ci-robot commented Aug 11, 2026 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Uh oh!

coderabbitai Bot commented Aug 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Uh oh!

radeore commented Aug 13, 2026

Uh oh!

radeore commented Aug 13, 2026

Uh oh!

openshift-ci-robot commented Aug 14, 2026 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Uh oh!

openshift-ci Bot commented Aug 27, 2026

Uh oh!

openshift-ci Bot commented Aug 27, 2026

Uh oh!

openshift-ci Bot commented Aug 31, 2026

Uh oh!

openshift-ci Bot commented Sep 1, 2026

Uh oh!

jsafrane commented Sep 1, 2026

Uh oh!

openshift-merge-bot Bot commented Sep 1, 2026

Uh oh!

openshift-ci Bot commented Sep 1, 2026

Uh oh!

jsafrane commented Sep 1, 2026

Uh oh!

openshift-ci Bot commented Sep 2, 2026

Uh oh!

jsafrane commented Sep 2, 2026

Uh oh!

openshift-ci Bot commented Sep 2, 2026

Uh oh!

radeore commented Sep 2, 2026

Uh oh!

openshift-ci-robot commented Sep 2, 2026 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jsafrane commented Sep 3, 2026

Uh oh!

openshift-ci Bot commented Sep 3, 2026

Uh oh!

radeore commented Sep 3, 2026

Uh oh!

radeore commented Sep 3, 2026

Uh oh!

openshift-ci Bot commented Sep 3, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

radeore commented Aug 11, 2026 •

edited

Loading

openshift-ci-robot commented Aug 11, 2026 •

edited by openshift-ci Bot

Loading

coderabbitai Bot commented Aug 11, 2026 •

edited

Loading

openshift-ci-robot commented Aug 14, 2026 •

edited by openshift-ci Bot

Loading

openshift-ci-robot commented Sep 2, 2026 •

edited by openshift-ci Bot

Loading