-
Notifications
You must be signed in to change notification settings - Fork 2.4k
STOR-2973: CI implementation: Validate Storage on GCP Dedicated #81996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
4e24235
STOR-2973: Add CSI storage certification workflow for GCD
rvagner78 e347739
STOR-2973: Add CSI storage certification workflow for GCD, env variables
rvagner78 458419d
STOR-2968: skip tests that assume GCP infrastructure that doesn't exi…
rvagner78 6eb38ea
STOR-2968: revert: skip tests that assume GCP infrastructure that doe…
rvagner78 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| approvers: | ||
| - storage-approvers | ||
|
|
||
| reviewers: | ||
| - storage-reviewers |
11 changes: 11 additions & 0 deletions
11
ci-operator/step-registry/openshift/e2e/gcd/csi/openshift-e2e-gcd-csi-workflow.metadata.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| { | ||
| "path": "openshift/e2e/gcd/csi/openshift-e2e-gcd-csi-workflow.yaml", | ||
| "owners": { | ||
| "approvers": [ | ||
| "storage-approvers" | ||
| ], | ||
| "reviewers": [ | ||
| "storage-reviewers" | ||
| ] | ||
| } | ||
| } |
36 changes: 36 additions & 0 deletions
36
ci-operator/step-registry/openshift/e2e/gcd/csi/openshift-e2e-gcd-csi-workflow.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| workflow: | ||
| as: openshift-e2e-gcd-csi | ||
| steps: | ||
| allow_best_effort_post_steps: true | ||
| pre: | ||
| - chain: ipi-gcd-pre | ||
| - ref: storage-conf-csi-gcp-pd | ||
| - ref: storage-obj-save | ||
| test: | ||
| - ref: openshift-e2e-test | ||
| post: | ||
| - ref: storage-obj-check | ||
| - chain: gather-core-dump | ||
| - chain: ipi-gcp-post | ||
| - ref: gcp-deprovision-bastionhost | ||
| - ref: gcp-deprovision-vpc | ||
| env: | ||
| BASE_DOMAIN: ci.gcd.devcluster.openshift.com | ||
| BASTION_IMAGE_NAME: fedora-coreos-41-20241122-3-0-gcp-x86-64 | ||
| BASTION_IMAGE_PROJECT: eu0:openshift | ||
| BASTION_MACHINE_TYPE: c3-standard-4 | ||
| COMPUTE_DISK_TYPE: hyperdisk-balanced | ||
| COMPUTE_NODE_REPLICAS: "2" | ||
| COMPUTE_NODE_TYPE: c3-standard-4 | ||
| CONTROL_PLANE_DISK_TYPE: hyperdisk-balanced | ||
| CONTROL_PLANE_NODE_TYPE: c3-standard-8 | ||
| DEFAULT_MACHINE_OSIMAGE: projects/eu0:openshift/images/rhcos10 | ||
| FEATURE_SET: TechPreviewNoUpgrade | ||
| PUBLISH: Internal | ||
| TEST_CSI_DRIVER_MANIFEST: manifest-gcp-pd.yaml | ||
| TEST_OCP_CSI_DRIVER_MANIFEST: ocp-manifest-gcp-pd.yaml | ||
| TEST_SUITE: openshift/csi | ||
| documentation: |- | ||
| The OpenShift E2E GCD CSI workflow executes the openshift/csi end-to-end | ||
| test suite on a private cluster on Google Cloud Dedicated using the | ||
| GCP PD CSI driver with hyperdisk-balanced storage. |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You may want to SKIP the tests we're skipping here:
https://github.com/openshift/release/blob/main/ci-operator/config/openshift/installer/openshift-installer-main.yaml#L556
Also, I think we're going to need to skip the test
API LBs follow /readyz of kube-apiserver and stop sending requestsso you should probably add that in as wellThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, updated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Finally it looks like we don't need SKIP_TEST in our job, because we don't run them anyway.
The /pj-rehearse pull-ci-openshift-csi-operator-release-5.0-e2e-gcd-csi passed and CSI storage tests were executed.