(multiple) Set test_operator as default test role#3954
Conversation
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
kstrenkova
force-pushed
the
deprecate-tempest-role
branch
from
0fbcdb2 to
a2504e9
Compare
kstrenkova
changed the title
|
Build failed (check pipeline). Post ✔️ openstack-k8s-operators-content-provider SUCCESS in 4h 39m 19s |
kstrenkova
force-pushed
the
deprecate-tempest-role
branch
from
a2504e9 to
0c842a6
Compare
|
Build failed (check pipeline). Post ✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 27m 37s |
|
This PR is stale because it has been for over 15 days with no activity. |
|
recheck |
michburk
left a comment
michburk
left a comment
There was a problem hiding this comment.
One naming mixup that I think has existed for quite a while now.
Other than that, the approach looks sound and I think this a good use of group vars 👍.
| * `cifmw_reportportal_datarouter_username`: (String) username for Data router client (mandatory). | ||
| * `cifmw_reportportal_datarouter_password`: (String) password for Data router client (mandatory). | ||
| * `cifmw_reportportal_datarouter_result_dir`: (String) Test results directory. Based on `cifmw_run_test_role` defaults to `~/ci-framework-data/tests/tempest/` or `~/ci-framework-data/tests/test_operator/`. One or more properly formatted xml results files are expected to be found in this directory. | ||
| * `cifmw_reportportal_datarouter_result_dir`: (String) Test results directory. Based on `cifmw_run_test_role` defaults to `~/ci-framework-data/tests/test_operator/`. One or more properly formatted xml results files are expected to be found in this directory. |
There was a problem hiding this comment.
I notice that in roles/reportportal/defaults/main.yml you edit the var cifmw_reportportal_results_dir and here in the README you adjust the entry for cifmw_reportportal_datarouter_result_dir.
If I understand correctly, I think we've stumbled upon an existing var naming mixup here, as cifmw_reportportal_datarouter_result_dir is never set/used anywhere in the cifmw, and a search on hound shows that cifmw_reportportal_datarouter_result_dir is only ever set but never used in cifmw-jobs.
I'm assuming we can change
* 'cifmw_reportportal_datarouter_result_dir`: (String) Test results directory...
to be
* 'cifmw_reportportal_results_dir`: (String) Test results directory...
There was a problem hiding this comment.
Good catch! I have updated it.
I also ran it through Claude to see if there are any other such mistakes in the reportportal role. Hence I have updated cifmw_reportportal_droute_version in README to latest, as it is in the defaults/main.yaml.
kstrenkova
force-pushed
the
deprecate-tempest-role
branch
from
0c842a6 to
812f365
Compare
Set cifmw_run_test_role to test_operator as a default and remove redundant explicit settings from scenarios. This is an effort to deprecate the tempest role and to reduce repetition of setting this variable to test_operator almost every time. Signed-off-by: Katarina Strenkova <kstrenko@redhat.com>
kstrenkova
force-pushed
the
deprecate-tempest-role
branch
from
812f365 to
449e31a
Compare
|
Build failed (check pipeline). Post ✔️ openstack-k8s-operators-content-provider SUCCESS in 4h 26m 37s |
|
recheck |
3 participants
Set cifmw_run_test_role to test_operator as a default and remove redundant explicit settings from scenarios. This is an effort to deprecate the tempest role and to reduce repetition of setting this variable to test_operator almost every time.
Signed-off-by: Katarina Strenkova kstrenko@redhat.com