fix(sdk): Lets ML-KEM PQ key encapsulation work#370
Conversation
|
Warning Review limit reached
Next review available in: 4 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
X-Test Failure Report |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces support for ML-KEM-768 key encapsulation, a post-quantum cryptographic algorithm. Key changes include the addition of the MLKEM768Key type to the KeyType enum, the implementation of the MLKEMEncryption class using Bouncy Castle, and integration within the TDF manifest creation process. Feedback focuses on improving resource management in MLKEMEncryption by using try-with-resources for the PEMParser, optimizing performance through the reuse of a static SecureRandom instance, and adding validation to ensure the generated ciphertext matches the expected length.
dmihalcik-virtru
force-pushed
the
DSPX-2399-java-sdk
branch
from
60df059 to
aa42e1a
Compare
X-Test Failure Report |
dmihalcik-virtru
changed the title
dmihalcik-virtru
force-pushed
the
DSPX-2399-java-sdk
branch
from
e4c46eb to
1a5abbd
Compare
Signed-off-by: Dave Mihalcik <dmihalcik@virtru.com>
…m-branch.yaml Signed-off-by: Dave Mihalcik <dmihalcik@virtru.com>
dmihalcik-virtru
force-pushed
the
DSPX-2399-java-sdk
branch
from
1a5abbd to
0bfd247
Compare
|
2 participants
Fixes missing cases to unwrap ML-KEM 768 and 1024 post-quantum key encapsulation for the Java SDK as part of the
mechanism-mlkemfeature.