CVS-177198 LLM Memory Usage tests - #4360
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the functional-test resource monitoring utilities to better support LLM long-tests focused on memory usage, including additional memory breakdown metrics and Windows support.
Changes:
- Extend Docker resource monitoring to capture additional memory metrics (private/anon vs cache) and add an efficient “sample all metrics” path.
- Introduce a Windows resource monitor that collects process memory stats via PowerShell and writes them to artifacts.
- Update OVMS run context to attach the correct resource monitor depending on Docker vs Windows execution.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tests/functional/object_model/resource_monitor.py | Adds extra Docker memory metrics, introduces sample_all(), and implements a new Windows resource monitor with CSV logging. |
| tests/functional/object_model/ovms_instance.py | Attaches Docker vs Windows resource monitors based on runtime environment and available OVMS PID. |
porlows1
force-pushed
the
porlows1_memory_tests_update
branch
from
July 9, 2026 08:11
3125006 to
3f5b5c7
Compare
porlows1
force-pushed
the
porlows1_memory_tests_update
branch
2 times, most recently
from
July 20, 2026 18:36
ba38983 to
511eab6
Compare
porlows1
force-pushed
the
porlows1_memory_tests_update
branch
2 times, most recently
from
July 31, 2026 17:55
5aac6ff to
ca77445
Compare
porlows1
force-pushed
the
porlows1_memory_tests_update
branch
3 times, most recently
from
August 12, 2026 08:03
c1ac16a to
daac116
Compare
porlows1
force-pushed
the
porlows1_memory_tests_update
branch
from
August 12, 2026 20:56
daac116 to
d0340ad
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.
Suppressed comments (2)
tests/functional/object_model/resource_monitor.py:267
- When writing CSV files on Windows, opening the file without
newline=""can produce extra blank lines due to newline translation. Usenewline=""when opening the file forcsv.DictWriter.
log_path = Path(artifacts_dir, f"windows_stats_pid_{self.ovms_pid}.log")
with log_path.open("w") as csvfile:
writer = csv.DictWriter(csvfile, fieldnames=self.FIELDS)
tests/functional/object_model/ovms_log_monitor.py:389
get_all_logs()always callsself._proc.get_output()first, which drains stdout from the shared stream queue viapop(). That defeats the mirror-file logic below (and contradicts the comment) because other monitors / log-saving code will still miss those stdout lines even when a mirror file exists. Reorder the logic so stdout is only popped when there is no mirror, and in the mirror case only drain stderr (if needed) while reading stdout from the mirror tail.
def get_all_logs(self):
stdout, stderr = self._proc.get_output()
if stderr:
ngrozae
approved these changes
Aug 13, 2026
pgladkows
approved these changes
Aug 13, 2026
dtrawins
pushed a commit
that referenced
this pull request
Aug 17, 2026
### 🛠 Summary [CVS-177198](https://jira.devtools.intel.com/browse/CVS-177198) Update long tests for LLMs memory usage Changes in tests related files required by intel-innersource/frameworks.ai.openvino.model-server.tests#2684 ### 🧪 Checklist - [ ] Unit tests added. - [ ] The documentation updated. - [ ] Change follows security best practices. ``
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary
CVS-177198 Update long tests for LLMs memory usage
Changes in tests related files required by https://github.com/intel-innersource/frameworks.ai.openvino.model-server.tests/pull/2684
🧪 Checklist
``