Skip to content

Fix named REST probe port in KServe runtime - #4453

Open
lusoris wants to merge 2 commits into
openvinotoolkit:mainfrom
lusoris:fix/kserve-rest-probe-port
Open

Fix named REST probe port in KServe runtime#4453
lusoris wants to merge 2 commits into
openvinotoolkit:mainfrom
lusoris:fix/kserve-rest-probe-port

Conversation

@lusoris

@lusoris lusoris commented Aug 15, 2026

Copy link
Copy Markdown

🛠 Summary

JIRA/Issue: N/A (external bug fix).

extras/kserve/kserve-openvino.yaml configures the startup probe with the
named port rest, but the container does not declare a port with that name.
Kubernetes resolves string probe ports against the container's named ports, so
the generated predictor pod cannot resolve rest.

Declare the REST container port as rest/TCP 8080. This matches the existing
--rest_port=8080 argument and lets the existing named startup probe resolve
without changing the server endpoint.

🧪 Checklist

  • Unit tests added. Not applicable: this is a declarative manifest repair;
    the focused structural assertions below cover the broken contract.
  • The documentation updated. Not applicable: no user-facing behavior or
    option changes.
  • Change follows security best practices.

Validation:

  • Parsed the manifest with PyYAML.
  • Validated it against the KServe v0.20.0 ClusterServingRuntime OpenAPI
    schema.
  • Asserted that startupProbe.httpGet.port resolves to exactly one declared
    container port and that its value, 8080, matches --rest_port=8080.
  • git diff --check.

Copilot AI lite review requested due to automatic review settings August 15, 2026 11:31

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes a KServe ClusterServingRuntime manifest contract issue where the startup probe references a named port (rest) that was not declared on the container, preventing Kubernetes from resolving the probe port.

Changes:

  • Declares the REST container port as a named port rest on TCP/8080 to match --rest_port=8080.
  • Keeps the existing startup probe configuration intact by making the port reference resolvable.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread extras/kserve/kserve-openvino.yaml Outdated
@lusoris
lusoris force-pushed the fix/kserve-rest-probe-port branch from 57d57e6 to 62aa7da Compare August 15, 2026 12:08
@dtrawins
dtrawins requested a review from mzegla August 19, 2026 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants