Fix named REST probe port in KServe runtime - #4453
Open
lusoris wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a KServe ClusterServingRuntime manifest contract issue where the startup probe references a named port (rest) that was not declared on the container, preventing Kubernetes from resolving the probe port.
Changes:
- Declares the REST container port as a named port
reston TCP/8080 to match--rest_port=8080. - Keeps the existing startup probe configuration intact by making the port reference resolvable.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
lusoris
force-pushed
the
fix/kserve-rest-probe-port
branch
from
August 15, 2026 12:08
57d57e6 to
62aa7da
Compare
dtrawins
approved these changes
Aug 19, 2026
mzegla
approved these changes
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary
JIRA/Issue: N/A (external bug fix).
extras/kserve/kserve-openvino.yamlconfigures the startup probe with thenamed port
rest, but the container does not declare a port with that name.Kubernetes resolves string probe ports against the container's named ports, so
the generated predictor pod cannot resolve
rest.Declare the REST container port as
rest/TCP 8080. This matches the existing--rest_port=8080argument and lets the existing named startup probe resolvewithout changing the server endpoint.
🧪 Checklist
the focused structural assertions below cover the broken contract.
option changes.
Validation:
ClusterServingRuntimeOpenAPIschema.
startupProbe.httpGet.portresolves to exactly one declaredcontainer port and that its value, 8080, matches
--rest_port=8080.git diff --check.