Skip to content

update-whitelisted-libraries - #4460

Open
pgladkows wants to merge 2 commits into
mainfrom
update-whitelisted-libraries
Open

update-whitelisted-libraries#4460
pgladkows wants to merge 2 commits into
mainfrom
update-whitelisted-libraries

Conversation

@pgladkows

Copy link
Copy Markdown
Collaborator

🛠 Summary

JIRA/Issue if applicable.
Describe the changes.

🧪 Checklist

  • Unit tests added.
  • The documentation updated.
  • Change follows security best practices.
    ``

@pgladkows
pgladkows marked this pull request as ready for review August 18, 2026 13:47
@pgladkows
pgladkows requested review from dtrawins, ngrozae and przepeck and a lite review from Copilot August 18, 2026 13:47

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the SDL whitelist of libraries expected to be present under /ovms/lib/, adjusting the allowed Azure-related libraries and distro-specific differences.

Changes:

  • Removes libazurestorage.so / libcpprest.so from the COMMON library whitelist.
  • Adds modern Azure SDK libraries (libazure-core.so, libazure-storage-*.so) to the UBUNTU whitelist.
  • Adds libazurestorage.so / libcpprest.so to the REDHAT whitelist.
Suppressed comments (1)

tests/sdl/whitelists.py:101

  • Azure SDK libraries (libazure-core.so / libazure-storage-*.so) are currently whitelisted only for OvmsBaseType.UBUNTU, but the packaging script copies these libs into /ovms/lib for all Linux distros (see create_package.sh:37). This will likely cause SDL whitelist failures for REDHAT images where these libs are present but not allowed.
    OvmsBaseType.COMMON: {
        'libespeak-ng.so',
        'libgit2.so',
        'libOpenCL.so',
        'libopencv_calib3d.so',

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants