[face_recognition_demo] Fix ValueError in chr() for special key inputs - #4038
Open
ffaahhimm wants to merge 1 commit into
Open
[face_recognition_demo] Fix ValueError in chr() for special key inputs#4038ffaahhimm wants to merge 1 commit into
ffaahhimm wants to merge 1 commit into
Conversation
Fixed a ValueError: chr() arg not in range(0x110000) that occurred when special keys (arrow keys, F1-F12, etc.) were pressed during face registration in the ask_to_save() method. Changed the else clause to elif 32 <= k <= 0x10FFFF to ensure only valid printable characters are passed to chr(k).
There was a problem hiding this comment.
Pull request overview
This PR fixes a crash in the face recognition demo’s interactive face registration flow by preventing invalid key codes from being passed to chr() when users press special keys in the ask_to_save() prompt (e.g., arrows, function keys).
Changes:
- Guard
chr(k)with a printable/valid Unicode range check inask_to_save()to avoidValueErroron special keys. - Minor comment cleanups in
cosine_dist()andmatch_faces().
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Can one of the admins verify this patch? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed a ValueError: chr() arg not in range(0x110000) that occurred
when special keys (arrow keys, F1-F12, etc.) were pressed during
face registration in the ask_to_save() method.
Changed the else clause to elif 32 <= k <= 0x10FFFF to ensure only
valid printable characters are passed to chr(k).
Fixes the bug reported in openvinotoolkit/openvino#34750