fully close most HTML tags in niceTables#1438
Merged
Merged
Conversation
drgrice1
approved these changes
Jun 13, 2026
drgrice1
left a comment
drgrice1
left a comment
Member
There was a problem hiding this comment.
Looks good. Fixes my initial MWE in the issue at least.
Alex-Jordan
force-pushed
the
nicetable-missingcell
branch
from
aef84a8 to
a369aff
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses #1182. If the
tagfunction is making an HTML tag and there is no content, close it like<div></div>. Only for a few exceptional tags, close it like<br>. The list of exceptional tags is not complete, but the ones left out are not reasonably going to arise in niceTables. In fact, I'm not sure the ones I listed will arise form niceTables either, but it's harmless to list them.