frp: add enable switch - #30484
Conversation
Add uci config options to enable/disable frpc and frps services independently. This allows users to control service startup via /etc/config/frpc and /etc/config/frps without modifying init scripts manually. Signed-off-by: Kissinger Zhou <kissinger@foxmail.com>
Add UCI configuration options to enable or disable frpc and frps services independently. This allows users to control service startup via /etc/config/frpc and /etc/config/frps without modifying init scripts manually. Signed-off-by: Kissinger Zhou <kissinger@foxmail.com>
After the pr, luci can add the switch option. |
openwrt-ai
left a comment
openwrt-ai
left a comment
There was a problem hiding this comment.
Commit checks
fd5489d"frp: add enable switch" — body describes adding the UCI enable/disable options, but the diff only bumpsPKG_RELEASEto 2. Squash it intoc040f46, which carries the actual change and is missing the release bump.
Generated by Claude Code
| config_foreach _find_init_section init | ||
|
|
||
| if [ -n "$init_cfg" ]; then | ||
| config_list_foreach "$init_cfg" conf_inc _append_conf_file |
There was a problem hiding this comment.
_append_conf_file appends to $CONF_FILE, and this loop now runs before mkdir -p /var/etc (line 940) and before : > "$CONF_FILE" (line 946) truncates it, so every conf_inc include is silently dropped from the generated TOML. The _TOML_ERR=0 reset at line 941 also clears any path-validation error this loop raised, so a rejected include no longer aborts startup either. Hoist only the config_get_bool/config_get reads and leave config_list_foreach "$init_cfg" conf_inc _append_conf_file at its original spot after the _emit_common block; same problem at frps.init:705.
Generated by Claude Code
|
|
||
| config_foreach _find_init_section init | ||
|
|
There was a problem hiding this comment.
nit: leftover blank run from the moved block; same at lines 743-745. frpc.init did not pick these up.
| config_foreach _find_init_section init |
Generated by Claude Code
|
I understand your feature requirements, but there are still a few minor issues with the current changes, and the code in the LuCI repository also needs to be updated accordingly. I will take over and complete the remaining work for you. Please be patient and wait. |
|
Please follow up on these two PRs (#30489 )(openwrt/luci#9013 )and test the off-the-shelf software package. |
Thanks, the PRs (#30489 )(openwrt/luci#9013 ) almost same as my bulid, so I think It will work fine. I will keep this active to check the different until #30489 into master. |
Formality Check: FailedWe checked this pull request against the contribution guidelines. Here is what needs your attention: 🛑 CRITICAL ERRORS
Tip Do not close this pull request to make corrections. Instead, modify your existing commits (e.g. Something broken? Consider reporting an issue. |
3 participants
Add feature to support uci enable config option
📦 Package Details
Maintainer: @kissingers
Description:
Add UCI configuration options to enable or disable frpc and frps
services independently.
This allows users to control service startup via /etc/config/frpc
and /etc/config/frps without modifying init scripts manually.
🧪 Run Testing Details
✅ Formalities
If your PR contains a patch:
git am(e.g., subject line, commit description, etc.)
We must try to upstream patches to reduce maintenance burden.